Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-20 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/ --- (Updated April 20, 2018, 11:44 a.m.) Review request for mesos, Akash Gupta,

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-18 Thread Joseph Wu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review201021 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-09 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200749 --- Ship it! Ship It! - Akash Gupta On April 6, 2018, 10:52

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-06 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/ --- (Updated April 6, 2018, 3:52 p.m.) Review request for mesos, Akash Gupta, Eric

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Andrew Schwartzmeyer
> On April 5, 2018, 4:07 p.m., Akash Gupta wrote: > > 3rdparty/stout/include/stout/os/windows/mktemp.hpp > > Line 54 (original), 54 (patched) > > > > > > Huh that's a strange function. Seems like it can cause time

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Andrew Schwartzmeyer
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200591 --- 3rdparty/stout/include/stout/os/windows/open.hpp Lines 37

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200579 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200579 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200579 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-05 Thread Akash Gupta
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200579 --- Fix it, then Ship it!

Re: Review Request 66424: Windows: Replaced `_wopen()` with `CreateFileW()` in `os::open()`.

2018-04-04 Thread John Kordich via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66424/#review200505 --- Ship it! Ship It! - John Kordich On April 4, 2018, 5:47