Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review201558 --- Ship it! Ship It! - Joseph Wu On April 4, 2018, 12:19 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66438/ > --- > > (Updated April 4, 2018, 12:19 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8675 > https://issues.apache.org/jira/browse/MESOS-8675 > > > Repository: mesos > > > Description > --- > > This is an edge case where a third-party library (libevent) requires a > CRT integer file descriptor. Thus we duplicate the `int_fd` and then > explicitly allocate via `crt()`, which requires that we also manually > close it via `_close()`. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 4de161dbf9198e9c74b1e80838b8a5d52006a562 > > > Diff: https://reviews.apache.org/r/66438/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review200614 --- Ship it! Ship It! - Akash Gupta On April 4, 2018, 7:19 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66438/ > --- > > (Updated April 4, 2018, 7:19 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8675 > https://issues.apache.org/jira/browse/MESOS-8675 > > > Repository: mesos > > > Description > --- > > This is an edge case where a third-party library (libevent) requires a > CRT integer file descriptor. Thus we duplicate the `int_fd` and then > explicitly allocate via `crt()`, which requires that we also manually > close it via `_close()`. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 4de161dbf9198e9c74b1e80838b8a5d52006a562 > > > Diff: https://reviews.apache.org/r/66438/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/#review200492 --- Ship it! Ship It! - John Kordich On April 4, 2018, 7:19 p.m., Andrew Schwartzmeyer wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66438/ > --- > > (Updated April 4, 2018, 7:19 p.m.) > > > Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, > and Michael Park. > > > Bugs: MESOS-8675 > https://issues.apache.org/jira/browse/MESOS-8675 > > > Repository: mesos > > > Description > --- > > This is an edge case where a third-party library (libevent) requires a > CRT integer file descriptor. Thus we duplicate the `int_fd` and then > explicitly allocate via `crt()`, which requires that we also manually > close it via `_close()`. > > > Diffs > - > > 3rdparty/libprocess/src/libevent_ssl_socket.cpp > 4de161dbf9198e9c74b1e80838b8a5d52006a562 > > > Diff: https://reviews.apache.org/r/66438/diff/1/ > > > Testing > --- > > > Thanks, > > Andrew Schwartzmeyer > >
Re: Review Request 66438: Windows: Made `libevent` use CRT file descriptor explicitly.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66438/ --- (Updated April 4, 2018, 12:19 p.m.) Review request for mesos, Akash Gupta, Eric Mumau, John Kordich, Joseph Wu, and Michael Park. Changes --- Changed ordering. Bugs: MESOS-8675 https://issues.apache.org/jira/browse/MESOS-8675 Repository: mesos Description --- This is an edge case where a third-party library (libevent) requires a CRT integer file descriptor. Thus we duplicate the `int_fd` and then explicitly allocate via `crt()`, which requires that we also manually close it via `_close()`. Diffs - 3rdparty/libprocess/src/libevent_ssl_socket.cpp 4de161dbf9198e9c74b1e80838b8a5d52006a562 Diff: https://reviews.apache.org/r/66438/diff/1/ Testing --- Thanks, Andrew Schwartzmeyer
