Re: Review Request 66450: Added missing gmock expectation.

2018-04-09 Thread Jan Schlicht

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200727
---


Ship it!




Ship It!

- Jan Schlicht


On April 4, 2018, 2:21 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66450/
> ---
> 
> (Updated April 4, 2018, 2:21 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing gmock expectation.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> 05ae5defb986103520cf630d5578e8a04e662313 
> 
> 
> Diff: https://reviews.apache.org/r/66450/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 66450: Added missing gmock expectation.

2018-04-04 Thread Mesos Reviewbot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200463
---



Patch looks great!

Reviews applied: [66450]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On April 4, 2018, 12:21 p.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66450/
> ---
> 
> (Updated April 4, 2018, 12:21 p.m.)
> 
> 
> Review request for mesos and Jan Schlicht.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added missing gmock expectation.
> 
> 
> Diffs
> -
> 
>   src/tests/resource_provider_manager_tests.cpp 
> 05ae5defb986103520cf630d5578e8a04e662313 
> 
> 
> Diff: https://reviews.apache.org/r/66450/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 66450: Added missing gmock expectation.

2018-04-04 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66450/#review200451
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66450']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450/logs/mesos-tests-stdout.log):

```
[   OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (116 ms)
[--] 9 tests from Endpoint/SlaveEndpointTest (1095 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (38 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (79 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (778 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (805 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (835 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (860 ms total)

[--] Global test environment tear-down
[==] 949 tests from 94 test cases ran. (449675 ms total)
[  PASSED  ] 948 tests.
[  FAILED  ] 1 test, listed below:
[  FAILED  ] CommandExecutorCheckTest.CommandCheckTimeout

 1 FAILED TEST
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66450/logs/mesos-tests-stderr.log):

```
I0404 14:07:49.860273  1312 slave.cpp:3877] Shutting down framework 
c825513f-2f38-457e-8e46-84e18a5adcd3-
I0404 14:07:49.860273 11164 master.cpp:10449] Updating the state of task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1 of framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0404 14:07:49.860273  1312 slave.cpp:6574] Shutting down executor 
'3d7109c1-513e-4035-b806-2d6fcc3d36e1' of framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- at executor(1)@10.3.1.8:61899
I0404 14:07:49.862273 10380 slave.cpp:923] Agent terI0404 14:07:49.681278 12564 
exec.cpp:162] Version: 1.6.0
I0404 14:07:49.709280 12740 exec.cpp:236] Executor registered on agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0
I0404 14:07:49.713281  3068 executor.cpp:176] Received SUBSCRIBED event
I0404 14:07:49.718281  3068 executor.cpp:180] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0404 14:07:49.718281  3068 executor.cpp:176] Received LAUNCH event
I0404 14:07:49.723280  3068 executor.cpp:648] Starting task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1
I0404 14:07:49.804282  3068 executor.cpp:483] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0404 14:07:49.831276  3068 executor.cpp:661] Forked command at 12432
I0404 14:07:49.862273 13084 exec.cpp:445] Executor asked to shutdown
I0404 14:07:49.862273 12940 executor.cpp:176] Received SHUTDOWN event
I0404 14:07:49.863270 12940 executor.cpp:758] Shutting down
I0404 14:07:49.863270 12940 executor.cpp:868] Sending SIGTERM to process tree 
at pid minating
W0404 14:07:49.863270 10380 slave.cpp:3873] Ignoring shutdown framework 
c825513f-2f38-457e-8e46-84e18a5adcd3- because it is terminating
I0404 14:07:49.863270 11164 master.cpp:10548] Removing task 
3d7109c1-513e-4035-b806-2d6fcc3d36e1 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework c825513f-2f38-457e-8e46-84e18a5adcd3- on 
agent c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 11164 master.cpp:1295] Agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net) disconnected
I0404 14:07:49.866276 11164 master.cpp:3286] Disconnecting agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 11164 master.cpp:3305] Deactivating agent 
c825513f-2f38-457e-8e46-84e18a5adcd3-S0 at slave(418)@10.3.1.8:61878 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0404 14:07:49.866276 14232 containerizer.cpp:2338]