Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

2018-04-20 Thread Gaston Kleiman

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66459/
---

(Updated April 20, 2018, 3:47 p.m.)


Review request for mesos and Greg Mann.


Changes
---

Rebased.


Repository: mesos


Description
---

A part of `Master::updateSlave()` doesn't account for operations created
via the operator API; this patch fixes that.


Diffs (updated)
-

  src/master/master.cpp 767ad8cfe142b47ef07172bcb2a4fb49fc3e833a 


Diff: https://reviews.apache.org/r/66459/diff/2/

Changes: https://reviews.apache.org/r/66459/diff/1-2/


Testing
---

`sudo bin/mesos-tests` on GNU/Linux


Thanks,

Gaston Kleiman



Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

2018-04-06 Thread Greg Mann

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66459/#review200658
---


Ship it!




Ship It!

- Greg Mann


On April 4, 2018, 11:49 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66459/
> ---
> 
> (Updated April 4, 2018, 11:49 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A part of `Master::updateSlave()` doesn't account for operations created
> via the operator API; this patch fixes that.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66459/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>



Re: Review Request 66459: Fixed bug in `Master::updateSlave()`.

2018-04-04 Thread Mesos Reviewbot Windows

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66459/#review200532
---



PASS: Mesos patch 66459 was successfully built and tested.

Reviews applied: `['66458', '66459']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66459

- Mesos Reviewbot Windows


On April 4, 2018, 4:49 p.m., Gaston Kleiman wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66459/
> ---
> 
> (Updated April 4, 2018, 4:49 p.m.)
> 
> 
> Review request for mesos and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> A part of `Master::updateSlave()` doesn't account for operations created
> via the operator API; this patch fixes that.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp 18382fa93fd0c59e641e00f2028ac1ae2e67c01c 
> 
> 
> Diff: https://reviews.apache.org/r/66459/diff/1/
> 
> 
> Testing
> ---
> 
> `sudo bin/mesos-tests` on GNU/Linux
> 
> 
> Thanks,
> 
> Gaston Kleiman
> 
>