Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Greg Mann 


> On April 17, 2018, 11:24 p.m., Greg Mann wrote:
> > src/tests/authorization_tests.cpp
> > Line 1979 (original), 1979 (patched)
> > 
> >
> > Could you also add an end-to-end test of authorization for these 
> > operations?
> 
> Zhitao Li wrote:
> Sure. Do you have an example or existing test to add this?

There are some similar tests in both 'persistent_volume_tests.cpp' as well as 
'master_authorization_tests.cpp'.

Tests which do something very similar in the persistent volume tests are 
'PersistentVolumeTest.BadACLDropCreateAndDestroy' and 
'PersistentVolumeTest.GoodACLCreateThenDestroy'. It would be good to verify 
both the successful and failed authorization cases.


- Greg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201362
---


On April 19, 2018, 8:01 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 19, 2018, 8:01 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/3/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Zhitao Li 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/
---

(Updated April 19, 2018, 1:01 p.m.)


Review request for mesos, Chun-Hung Hsiao and Greg Mann.


Bugs: MESOS-8748
https://issues.apache.org/jira/browse/MESOS-8748


Repository: mesos


Description
---

Added test for authorization actions for `UPDATE_VOLUME`.


Diffs (updated)
-

  src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 


Diff: https://reviews.apache.org/r/66532/diff/3/

Changes: https://reviews.apache.org/r/66532/diff/2-3/


Testing
---


Thanks,

Zhitao Li

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-19 Thread Zhitao Li 


> On April 17, 2018, 4:24 p.m., Greg Mann wrote:
> > src/tests/authorization_tests.cpp
> > Line 1979 (original), 1979 (patched)
> > 
> >
> > Could you also add an end-to-end test of authorization for these 
> > operations?

Sure. Do you have an example or existing test to add this?


- Zhitao


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201362
---


On April 10, 2018, 12:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 10, 2018, 12:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201364
---




src/tests/authorization_tests.cpp
Lines 2155 (patched)


Some of your comments use double-quotes around principal and role names, 
while others use backticks. It looks to me like double-quotes are more common 
in this file - could you make them consistent?


- Greg Mann


On April 10, 2018, 7:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 10, 2018, 7:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-17 Thread Greg Mann 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review201362
---




src/tests/authorization_tests.cpp
Line 1979 (original), 1979 (patched)


Could you also add an end-to-end test of authorization for these operations?


- Greg Mann


On April 10, 2018, 7:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 10, 2018, 7:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-11 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review200943
---



PASS: Mesos patch 66532 was successfully built and tested.

Reviews applied: `['66218', '66049', '66050', '66568', '66219', '66220', 
'66569', '66052', '66051', '66227', '66531', '66532']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66532

- Mesos Reviewbot Windows


On April 10, 2018, 7:24 p.m., Zhitao Li wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/66532/
> ---
> 
> (Updated April 10, 2018, 7:24 p.m.)
> 
> 
> Review request for mesos, Chun-Hung Hsiao and Greg Mann.
> 
> 
> Bugs: MESOS-8748
> https://issues.apache.org/jira/browse/MESOS-8748
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added test for authorization actions for `UPDATE_VOLUME`.
> 
> 
> Diffs
> -
> 
>   src/tests/authorization_tests.cpp a76ad18a54ec232e6d6c92ec6a45b445a83f174c 
> 
> 
> Diff: https://reviews.apache.org/r/66532/diff/2/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Zhitao Li
> 
>

Re: Review Request 66532: Added test for authorization actions for `UPDATE_VOLUME`.

2018-04-10 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66532/#review200841
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['66218', '66049', '66050', '66219', '66220', '66052', 
'66051', '66227', '66531', '66532']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66532

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66532/logs/mesos-tests-stdout.log):

```
[--] 9 tests from Endpoint/SlaveEndpointTest (1075 ms total)

[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (35 
ms)
[ RUN  ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1
[   OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (39 
ms)
[--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (76 ms 
total)

[--] 1 test from IsolationFlag/CpuIsolatorTest
[ RUN  ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0
[   OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (781 ms)
[--] 1 test from IsolationFlag/CpuIsolatorTest (808 ms total)

[--] 1 test from IsolationFlag/MemoryIsolatorTest
[ RUN  ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0
[   OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (838 ms)
[--] 1 test from IsolationFlag/MemoryIsolatorTest (867 ms total)

[--] Global test environment tear-down
[==] 957 tests from 94 test cases ran. (467339 ms total)
[  PASSED  ] 955 tests.
[  FAILED  ] 2 tests, listed below:
[  FAILED  ] 
ContentType/MasterAPITest.CreateGrowShrinkDestroyPersistentVolume/0, where 
GetParam() = application/x-protobuf
[  FAILED  ] 
ContentType/MasterAPITest.CreateGrowShrinkDestroyPersistentVolume/1, where 
GetParam() = application/json

 2 FAILED TESTS
  YOU HAVE 214 DISABLED TESTS

```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66532/logs/mesos-tests-stderr.log):

```
I0410 20:39:35.408179 22096 executor.cpp:177] Received SUBSCRIBED event
I0410 20:39:35.413197 22096 executor.cpp:181] Subscribed executor on 
winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net
I0410 20:39:35.413197 22096 executor.cpp:177] Received LAUNCH event
I0410 20:39:35.418190 22096 executor.cpp:649] Starting task 
ce703cd1-acd0-4725-9dd6-e47ab31e4432
I0410 20:39:35.509244 22096 executor.cpp:484] Running 
'D:\DCOS\mesos\src\mesos-containerizer.exe launch '
I0410 20:39:35.540205 22096 executor.cpp:662] Forked command at 21472
I0410 20:39:35.573182 21000 exec.cpp:445] Executor asked to shutdown
I0410 20:39:35.573182 21652 executor.cpp:177] Received SHUTDOWN event
I0410 20:39:35.573182 21652 executor.cpp:759] Shutting down
I0410 20:39:35.573182 21652 executor.cpp:869] Sending SIGTERM to process tree 
at pid .569183  6056 master.cpp:3249] Deactivating framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0- (default) at 
scheduler-2540719b-1b4b-470f-8809-e33a0b4a52bb@10.3.1.8:60882
I0410 20:39:35.571203 22988 hierarchical.cpp:405] Deactivated framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0-
I0410 20:39:35.571203 21372 slave.cpp:3973] Shutting down framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0-
I0410 20:39:35.571203  6056 master.cpp:10646] Updating the state of task 
ce703cd1-acd0-4725-9dd6-e47ab31e4432 of framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0- (latest state: TASK_KILLED, status 
update state: TASK_KILLED)
I0410 20:39:35.571203 21372 slave.cpp:6682] Shutting down executor 
'ce703cd1-acd0-4725-9dd6-e47ab31e4432' of framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0- at executor(1)@10.3.1.8:60903
I0410 20:39:35.572187 21372 slave.cpp:923] Agent terminating
W0410 20:39:35.572187 21372 slave.cpp:3969] Ignoring shutdown framework 
c6ab24ad-96d4-4f3c-b927-4659302996a0- because it is terminating
I0410 20:39:35.575168  6056 master.cpp:10745] Removing task 
ce703cd1-acd0-4725-9dd6-e47ab31e4432 with resources cpus(allocated: *):4; 
mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: 
*):[31000-32000] of framework c6ab24ad-96d4-4f3c-b927-4659302996a0- on 
agent c6ab24ad-96d4-4f3c-b927-4659302996a0-S0 at slave(425)@10.3.1.8:60882 
(winbldsrv-01.zq4gs31qjdiunm1ryi1452nvnh.dx.internal.cloudapp.net)
I0410 20:39:35.575168 21372 containerizer.cpp:2338] Destroying container 
936fac82-7c94-42ed-beb9-144facfa1da0 in RUNNING state
I0410 20:39:35.576180 21372 containerizer.cpp:2952] Transitioning the state of 
container 936fac82-7c94-42ed-beb9-144facfa1da0 from RUNNING to DESTROYING
I0410 20:39:35.577185 21372 launcher.cpp:156] Asked to de