Re: Review Request 66539: Fixed the agent recovery crash if metadata is missing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66539/#review200976 --- Ship it! Ship It! - Qian Zhang On April 11, 2018, 7:41 a.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66539/ > --- > > (Updated April 11, 2018, 7:41 a.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8416 > https://issues.apache.org/jira/browse/MESOS-8416 > > > Repository: mesos > > > Description > --- > > This is the case that is missed when handling orphan containers > cleanup. When the agent metadata does not exist but the container > pid is chechpointed under the container runtime dir, then the > container should be regarded as orphan and should be cleaned up. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > 7473a871e626833733f39375b778aff70529dc63 > > > Diff: https://reviews.apache.org/r/66539/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
Re: Review Request 66539: Fixed the agent recovery crash if metadata is missing.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66539/#review200859 --- Ship it! Ship It! - Jie Yu On April 10, 2018, 11:41 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66539/ > --- > > (Updated April 10, 2018, 11:41 p.m.) > > > Review request for mesos, Jie Yu, Kevin Klues, Qian Zhang, and Vinod Kone. > > > Bugs: MESOS-8416 > https://issues.apache.org/jira/browse/MESOS-8416 > > > Repository: mesos > > > Description > --- > > This is the case that is missed when handling orphan containers > cleanup. When the agent metadata does not exist but the container > pid is chechpointed under the container runtime dir, then the > container should be regarded as orphan and should be cleaned up. > > > Diffs > - > > src/slave/containerizer/mesos/containerizer.cpp > 7473a871e626833733f39375b778aff70529dc63 > > > Diff: https://reviews.apache.org/r/66539/diff/1/ > > > Testing > --- > > make check > > > Thanks, > > Gilbert Song > >
