Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-25 Thread Benjamin Bannier
> On April 25, 2018, 1:51 a.m., Chun-Hung Hsiao wrote: > > src/tests/resource_provider_manager_tests.cpp > > Lines 1155 (patched) > > > > > > Let's also add a test for resource provider manager recovery in another

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201879 --- src/tests/resource_provider_manager_tests.cpp Lines 1155

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201869 --- Ship it! Ship It! - Chun-Hung Hsiao On April 24, 2018, 7:28

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Benjamin Bannier
> On April 23, 2018, 11:51 p.m., Chun-Hung Hsiao wrote: > > src/resource_provider/manager.cpp > > Lines 683-692 (patched) > > > > > > Let's move this to r/66545. I think this patch makes a lot of sense on its own,

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-24 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/ --- (Updated April 24, 2018, 9:28 p.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-23 Thread Chun-Hung Hsiao
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201773 --- Please update the commit summary accordingly if you move the

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-23 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201735 --- Patch looks great! Reviews applied: [66508, 66308, 66309, 66526,

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-23 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201734 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-19 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review201519 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-12 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review200989 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-12 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/ --- (Updated April 12, 2018, 11:48 a.m.) Review request for mesos, Chun-Hung Hsiao

Re: Review Request 66546: Prevent resubscription of resource providers with unknown IDs.

2018-04-11 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66546/#review200906 --- FAIL: Some of the unit tests failed. Please check the relevant