Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

2018-04-16 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201257 --- Ship it! Ship It! - Gaston Kleiman On April 16, 2018, 9:51

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

2018-04-16 Thread James Peach
> On April 14, 2018, 12:25 a.m., Gaston Kleiman wrote: > > Thanks for the cleanup! > > > > I think we could get rid of quite some boilerplate with a helper that > > creates a `ContainerInfo::DockerInfo`. Good point! - James --- This

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

2018-04-13 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201156 --- Patch looks great! Reviews applied: [66615] Passed command:

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

2018-04-13 Thread Mesos Reviewbot Windows
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201148 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 66615: Adopted `createTask` helper API in Docker containerizer tests.

2018-04-13 Thread Gaston Kleiman
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66615/#review201146 --- Thanks for the cleanup! I think we could get rid of quite some