----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67202/#review203384 -----------------------------------------------------------
Fix it, then Ship it! Let's please explain the motivation for this change; something along these lines ``` Added `ContainerID` to the container logger interface to allow for tagging the output with that information. ``` include/mesos/slave/container_logger.hpp Lines 100 (patched) <https://reviews.apache.org/r/67202/#comment285582> We need to add this to the comment above.... `@param containerId ...`. We also should update the `CHANGELOG` again to stay accurate as it currently only mentions `ContainerConfig`. - Till Toenshoff On May 17, 2018, 10:29 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67202/ > ----------------------------------------------------------- > > (Updated May 17, 2018, 10:29 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Joseph Wu, and Till Toenshoff. > > > Bugs: MESOS-8920 > https://issues.apache.org/jira/browse/MESOS-8920 > > > Repository: mesos > > > Description > ------- > > Added ContainerID to container logger prepare interface. > > > Diffs > ----- > > include/mesos/slave/container_logger.hpp > 5fe236964146e8a5cae8c7badaff08c96584ee5a > src/slave/container_loggers/lib_logrotate.hpp > 303511cb6d8f4edfb99fd8206fb1a9fe5e7e5888 > src/slave/container_loggers/lib_logrotate.cpp > f0a59d05c00f1a8ad7a67f8fa837195a3502143f > src/slave/container_loggers/sandbox.hpp > 39e0eeb297bc12cf518b4fc909ba322fe77093d0 > src/slave/container_loggers/sandbox.cpp > ce4faecd07cf44e197bf4d6d2518a45140e8dc48 > src/slave/containerizer/docker.cpp 725cdb5df600b168fcee3ac9284c0c17bc7b313f > src/slave/containerizer/mesos/io/switchboard.cpp > d0f98adf324744a6ffb7ff9cfac5e6909d3a64eb > > > Diff: https://reviews.apache.org/r/67202/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Jie Yu > >
