Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- (Updated May 30, 2018, 2:56 a.m.) Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht. Changes --- Rebased. Repository: mesos Description --- To avoid double counting when the operator aggregates the `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, these two are now merged into `csi_plugin/container_terminations`. Diffs (updated) - src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 src/tests/storage_local_resource_provider_tests.cpp 04a75fc4d53d1b7211e64755097b06b1e68cc3b3 Diff: https://reviews.apache.org/r/67224/diff/4/ Changes: https://reviews.apache.org/r/67224/diff/3-4/ Testing --- sudo make check Thanks, Chun-Hung Hsiao
Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203910 --- Ship it! Ship It! - Jie Yu On May 24, 2018, 12:47 a.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67224/ > --- > > (Updated May 24, 2018, 12:47 a.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan > Schlicht. > > > Repository: mesos > > > Description > --- > > To avoid double counting when the operator aggregates the > `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, > these two are now merged into `csi_plugin/container_terminations`. > > > Diffs > - > > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > src/tests/storage_local_resource_provider_tests.cpp > 45cb38922f78941e82667a60b3b71ce220c9202f > > > Diff: https://reviews.apache.org/r/67224/diff/3/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- (Updated May 24, 2018, 12:47 a.m.) Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht. Changes --- Rebased. Repository: mesos Description --- To avoid double counting when the operator aggregates the `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, these two are now merged into `csi_plugin/container_terminations`. Diffs (updated) - src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f Diff: https://reviews.apache.org/r/67224/diff/3/ Changes: https://reviews.apache.org/r/67224/diff/2-3/ Testing --- sudo make check Thanks, Chun-Hung Hsiao
Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/ --- (Updated May 22, 2018, 11:35 p.m.) Review request for mesos, Benjamin Bannier, Greg Mann, Jie Yu, and Jan Schlicht. Changes --- Rebased. Repository: mesos Description --- To avoid double counting when the operator aggregates the `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, these two are now merged into `csi_plugin/container_terminations`. Diffs (updated) - src/resource_provider/storage/provider.cpp 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 src/tests/storage_local_resource_provider_tests.cpp 45cb38922f78941e82667a60b3b71ce220c9202f Diff: https://reviews.apache.org/r/67224/diff/2/ Changes: https://reviews.apache.org/r/67224/diff/1-2/ Testing --- sudo make check Thanks, Chun-Hung Hsiao
Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203550 --- Patch looks great! Reviews applied: [65665, 65666, 67224] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On May 18, 2018, 11:46 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67224/ > --- > > (Updated May 18, 2018, 11:46 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > To avoid double counting when the operator aggregates the > `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, > these two are now merged into `csi_plugin/container_terminations`. > > > Diffs > - > > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > src/tests/storage_local_resource_provider_tests.cpp > 45cb38922f78941e82667a60b3b71ce220c9202f > > > Diff: https://reviews.apache.org/r/67224/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
Re: Review Request 67224: Combined and renamed `csi_*_plugin_terminations` metrics.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67224/#review203469 --- PASS: Mesos patch 67224 was successfully built and tested. Reviews applied: `['65665', '65666', '67224']` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67224 - Mesos Reviewbot Windows On May 18, 2018, 11:46 p.m., Chun-Hung Hsiao wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67224/ > --- > > (Updated May 18, 2018, 11:46 p.m.) > > > Review request for mesos, Benjamin Bannier, Jie Yu, and Jan Schlicht. > > > Repository: mesos > > > Description > --- > > To avoid double counting when the operator aggregates the > `csi_controller_plugin_terminations` and `csi_node_plugin_terminations`, > these two are now merged into `csi_plugin/container_terminations`. > > > Diffs > - > > src/resource_provider/storage/provider.cpp > 63b5d7e5f10d6ad02b5cd11b119def3b4abf4180 > src/tests/storage_local_resource_provider_tests.cpp > 45cb38922f78941e82667a60b3b71ce220c9202f > > > Diff: https://reviews.apache.org/r/67224/diff/1/ > > > Testing > --- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
