subject:"Re\: Review Request 67488\: Updated CLI to Python 3."

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-17 Thread Andrew Schwartzmeyer



> On July 16, 2018, 1:32 p.m., Andrew Schwartzmeyer wrote:
> > Did you have an automated way of finding where we should apply `override` 
> > in existing code? I'd like to see if there's any Windows-only code/tests we 
> > should fix too.
> 
> Armand Grillet wrote:
> What do you mean by `override`? I have applied `2to3` on the CLI codebase 
> to find what needed to be updated. I haven't run `mesos-cli-tests` on a 
> Windows machine, that should tell us if we need to fix something else for 
> that operating system.

Wrong review... I think I was copy-pasting and had a couple tabs open. Sorry!


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206125
---


On July 6, 2018, 6:56 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 6:56 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-17 Thread Armand Grillet



> On July 16, 2018, 8:32 p.m., Andrew Schwartzmeyer wrote:
> > Did you have an automated way of finding where we should apply `override` 
> > in existing code? I'd like to see if there's any Windows-only code/tests we 
> > should fix too.

What do you mean by `override`? I have applied `2to3` on the CLI codebase to 
find what needed to be updated. I haven't run `mesos-cli-tests` on a Windows 
machine, that should tell us if we need to fix something else for that 
operating system.


- Armand


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206125
---


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Andrew Schwartzmeyer


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206125
---


Ship it!




Did you have an automated way of finding where we should apply `override` in 
existing code? I'd like to see if there's any Windows-only code/tests we should 
fix too.

- Andrew Schwartzmeyer


On July 6, 2018, 6:56 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 6:56 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206106
---


Ship it!




Ship It!

- Kevin Klues


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206104
---


Ship it!




Ship It!

- Kevin Klues


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-16 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206105
---


Ship it!




Ship It!

- Kevin Klues


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-13 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206069
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67911', '67910', '67906', '67907', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1920/mesos-review-67488

- Mesos Reviewbot Windows


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/12/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-13 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review206051
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67907', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1918/mesos-review-67488

- Mesos Reviewbot Windows


On July 6, 2018, 6:56 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 6:56 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am db42e71d90ff2066e104f4b9c269c5e78a9a6ada 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
>   src/python/lib/tox.ini 05b633e837fa39a36fb2c5a0778513ce743099db 
>   support/mesos-style.py 27ed553cb1d9e0c3c750b414eafe0144c3442c43 
>   support/python3/mesos-style.py 350ef909e3e7a1c927140cf4475547d704ac2ad5 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/11/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-11 Thread Benjamin Bannier


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205963
---



cmake-related changes LGTM, left a few minor comments.


cmake/CompilationConfigure.cmake
Line 134 (original), 134-142 (patched)


Let's document these as `Command for the Python interpreter`.

Also, no need to explicitly document default values here.



cmake/CompilationConfigure.cmake
Line 140 (original), 159 (patched)


Add a comment that this will look for interpreters going from newest to 
oldest (we e.g., wouldn't want to find a py26 here if we had both py26 and py37 
installed).



src/python/cli_new/CMakeLists.txt
Line 54 (original), 54-55 (patched)


I had some trouble parsing this as an env var, suggest to rewrap, e.g.,

add_custom_command(
OUTPUT .virtualenv/bin/activate
COMMAND
  VIRTUALENV_DIRECTORY=${CMAKE_CURRENT_BINARY_DIR}/.virtualenv
  PYTHON=${PYTHON_3}
  ${CMAKE_CURRENT_SOURCE_DIR}/bootstrap
<...> # other stuff


- Benjamin Bannier


On July 6, 2018, 3:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 3:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-10 Thread Eric Chung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205956
---




src/python/cli_new/lib/cli/http.py
Line 74 (original), 74 (patched)


`str()` is probably not necessary



src/python/cli_new/lib/cli/util.py
Line 151 (original), 151 (patched)


`len() != 0` is redundant, also `list()` should only have to be called once.



src/python/cli_new/tox.ini
Line 7 (original), 7 (patched)


if you specifically would like py37 to work, probably add it here as well, 
e.g. `{py36,py37}-{lint,test}`, then add
```
basepython =
  py36: python3.6
  py37: python3.7
```
the cardinality of the tests will grow as `n x m`, so maybe keep the list 
of supported python versions below 3


- Eric Chung


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-09 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205881
---



Patch looks great!

Reviews applied: [67853, 67855, 67856, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-09 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205858
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67853', '67855', '67856', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1885/mesos-review-67488

- Mesos Reviewbot Windows


On July 6, 2018, 1:56 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated July 6, 2018, 1:56 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 89360e6cac5ca910044a5a82fab7237510edee7f 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/10/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205810
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67488']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (597 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1324 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (798 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1014 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (598 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5072 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5065 ms)
[--] 24 tests from DockerContainerizerTest (90708 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00ADD15EBEE0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00ADD15EC140.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01EF07026460.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @01EF072A8CB0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @01EF07418FF8.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stderr.log):

```
I0706 16:46:11.458655 17676 authenticatee.cpp:299] Authentication success
I0706 16:46:11.459653  9788 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-cb521b1e-0dcf-40c9-83bf-a91f5d1fec3e@192.10.1.6:60191
I0706 16:46:11.460650 15632 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:60191
I0706 16:46:11.460650 16292 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-cb521b1e-0dcf-40c9-83bf-a91f5d1fec3e@192.10.1.6:60191
I0706 16:46:11.460650 16292 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0706 16:46:11.461657  9788 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0706 16:46:11.462653  9788 master.cpp:9993] Adding framework 
c76c303f-bc61-4770-a4bb-e66cfe7c4451- (default) at 
scheduler-cb521b1e-0dcf-40c9-83bf-a91f5d1fec3e@192.10.1.6:60191 with roles {  } 
suppressed
I0706 16:46:11.463651 18064 sched.cpp:749] Framework registered with 
c76c303f-bc61-4770-a4bb-e66cfe7c4451-
I0706 16:46:11.464651 17508 hierarchical.cpp:299] Added framework 
c76c303f-bc61-4770-a4bb-e66cfe7c4451-
E0706 16:46:11.551367 16292 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-06 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205804
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67842', '67488']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (801 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1232 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (799 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (804 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1006 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (597 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5361 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4960 ms)
[--] 24 tests from DockerContainerizerTest (91261 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00B78952BBC0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00B78952BE20.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @029DA2DE07B8.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @029DA2EBB690.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @029DA4390BF0.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stderr.log):

```
I0706 15:02:09.007192 14288 authenticatee.cpp:299] Authentication success
I0706 15:02:09.007192  3668 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-589bd31b-e975-47a7-91f3-a1c348629a69@192.10.1.6:59020
I0706 15:02:09.008174 10180 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:59020
I0706 15:02:09.009182 16728 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-589bd31b-e975-47a7-91f3-a1c348629a69@192.10.1.6:59020
I0706 15:02:09.010175 16728 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0706 15:02:09.011175  3668 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0706 15:02:09.011175  3668 master.cpp:9993] Adding framework 
a2d466cb-cbe4-4c17-b5bd-9a8cdeadb157- (default) at 
scheduler-589bd31b-e975-47a7-91f3-a1c348629a69@192.10.1.6:59020 with roles {  } 
suppressed
I0706 15:02:09.012173  6132 sched.cpp:749] Framework registered with 
a2d466cb-cbe4-4c17-b5bd-9a8cdeadb157-
I0706 15:02:09.013175 15712 hierarchical.cpp:299] Added framework 
a2d466cb-cbe4-4c17-b5bd-9a8cdeadb157-
E0706 15:02:09.101181 14288 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-06 Thread Armand Grillet


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/
---

(Updated July 6, 2018, 1:56 p.m.)


Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
and Kevin Klues.


Changes
---

Rebased and improved CMake Python detection.


Bugs: MESOS-8955
https://issues.apache.org/jira/browse/MESOS-8955


Repository: mesos


Description
---

The build tools are also up to date thus the CLI can still be built
using Autotools and CMake. No features have been added to the CLI.

The PyInstaller dependency has been updated due to issues with
PyInstaller 3.1.1 and Python 3.6.


Diffs (updated)
-

  cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
  configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
  src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
  src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
  src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
  src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
  src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
  src/python/cli_new/lib/cli/config.py 6f92622725d8a042a2a728fd38c977ac690ef6be 
  src/python/cli_new/lib/cli/docopt.py 86a4e9c74326fb80cc59487113f07358dd96960d 
  src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
  src/python/cli_new/lib/cli/plugins/agent/main.py 
59280ece8ebd00bb96df3675b6356a26cc48a2c0 
  src/python/cli_new/lib/cli/plugins/base.py 
e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
  src/python/cli_new/lib/cli/plugins/task/main.py 
cc6cff56c71262729a8870017bef2e97636abe5a 
  src/python/cli_new/lib/cli/tests/base.py 
4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
  src/python/cli_new/lib/cli/tests/tests.py 
79e1036f6d11c63884091fe43672607b03955c1a 
  src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
  src/python/cli_new/pip-requirements.txt 
aeb023325e838aa42f8d7418bb7f8293c3fa5614 
  src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
  src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 


Diff: https://reviews.apache.org/r/67488/diff/9/

Changes: https://reviews.apache.org/r/67488/diff/8-9/


Testing
---

Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
Python 3.5 and `python36` being Python 3.6.


For Autotools:

```
$ ./bootstrap
$ mkdir build
$ cd build
$ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
$ make check
```

For CMake:

```
$ ./bootstrap
$ mkdir build
$ cd build
$ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
$ cmake --build . -- -j16
$ ./src/mesos
Mesos CLI

Usage:
  mesos (-h | --help)
  mesos --version
  mesos  [...]

Options:
  -h --help  Show this screen.
  --version  Show version info.

Commands:
  agent   Interacts with the Mesos agents
  config  Interacts with the Mesos CLI configuration file
  taskInteracts with the tasks running in a Mesos cluster

See 'mesos help ' for more information on a specific command.
$ cmake --build . --target tests -- -j16
$ ctest -R CLI
Test project /home/agrillet/apache-mesos/build
Start 4: CLITests
1/1 Test #4: CLITests .   Passed3.63 sec

100% tests passed, 0 tests failed out of 1
```

Checked that the the CLI tests were run, that the content of the directory 
build/src/cli was as expected, and that build/src/mesos was correctly running.


Thanks,

Armand Grillet

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-06 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205795
---



Patch looks great!

Reviews applied: [67411, 67412, 67413, 67487, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 13, 2018, 12:29 a.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 13, 2018, 12:29 a.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 66cc28a5a34949bcadc038551249f3781ea9d45b 
>   src/Makefile.am 3ac1e1ce650d7238c108d0ac4123228500053a6f 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/8/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-05 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205742
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67488']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (796 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1322 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1002 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (601 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5060 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (4858 ms)
[--] 24 tests from DockerContainerizerTest (89904 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00901419B8A0.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00901419BB00.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @027B4512C090.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @027B45B77BD0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @027B46F7F738.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stderr.log):

```
I0705 14:24:38.341552 11648 authenticatee.cpp:299] Authentication success
I0705 14:24:38.342562 13080 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-b9beba28-fb2f-4472-b9c5-60adca8aa1be@192.10.1.6:51840
I0705 14:24:38.342562 10324 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:51840
I0705 14:24:38.344561 13352 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-b9beba28-fb2f-4472-b9c5-60adca8aa1be@192.10.1.6:51840
I0705 14:24:38.344561 13352 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0705 14:24:38.345543 13080 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0705 14:24:38.345543 13080 master.cpp:9993] Adding framework 
50acb31d-9a6e-4ab0-8b9a-6d21149a648b- (default) at 
scheduler-b9beba28-fb2f-4472-b9c5-60adca8aa1be@192.10.1.6:51840 with roles {  } 
suppressed
I0705 14:24:38.346565 13064 sched.cpp:749] Framework registered with 
50acb31d-9a6e-4ab0-8b9a-6d21149a648b-
I0705 14:24:38.347561  4344 hierarchical.cpp:299] Added framework 
50acb31d-9a6e-4ab0-8b9a-6d21149a648b-
E0705 14:24:38.441642 13812 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not recognized as

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-04 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205727
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67487', '67488']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (802 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (599 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1420 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (902 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (800 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1108 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (696 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5664 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5470 ms)
[--] 24 tests from DockerContainerizerTest (97421 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @008EDFEFBD70.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @008EDFEFBFD0.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @0275F1101928.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0275F1911090.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @0275F1B1F740.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stderr.log):

```
I0704 15:19:03.925571  6532 authenticatee.cpp:299] Authentication success
I0704 15:19:03.925571  9608 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-0c8b9153-5533-42b1-b45b-1a78becc22ac@192.10.1.5:58005
I0704 15:19:03.926615  8516 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.5:58005
I0704 15:19:03.927549  6532 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-0c8b9153-5533-42b1-b45b-1a78becc22ac@192.10.1.5:58005
I0704 15:19:03.928551  6532 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0704 15:19:03.929548  8708 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0704 15:19:03.930554  8708 master.cpp:9993] Adding framework 
9a7d6b83-f94d-4e34-b532-6b10ddc23d1a- (default) at 
scheduler-0c8b9153-5533-42b1-b45b-1a78becc22ac@192.10.1.5:58005 with roles {  } 
suppressed
I0704 15:19:03.931571  9812 sched.cpp:749] Framework registered with 
9a7d6b83-f94d-4e34-b532-6b10ddc23d1a-
I0704 15:19:03.932554  6952 hierarchical.cpp:299] Added framework 
9a7d6b83-f94d-4e34-b532-6b10ddc23d1a-
E0704 15:19:04.017592  9796 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is not

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-04 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205726
---




src/python/cli_new/lib/cli/tests/base.py
Line 119 (original), 119 (patched)


Why did we change this?



src/python/cli_new/lib/cli/tests/base.py
Lines 143 (patched)


Why terminate instead of kill? Terminate shuts down gracefully, while kill 
forces the process to die immediately.


- Kevin Klues


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 61387d77b12a17571a31430db3ca1fe0bbb66a21 
>   configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 
>   src/Makefile.am de808205f59a485d758d1baf9d990bc631eb8c5c 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/7/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-07-04 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205720
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67413', '67487', '67488']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

Relevant logs:

- 
[mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stdout.log):

```
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyWhilePulling (803 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DestroyUnknownContainer (601 
ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_ExecutorCleanupWhenLaunchFailed (1326 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_FetchFailure (902 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerPullFailure (804 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DockerInspectDiscard (1003 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer
[   OK ] DockerContainerizerTest.ROOT_DOCKER_WaitUnknownContainer (595 ms)
[ RUN  ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning
[   OK ] 
DockerContainerizerTest.ROOT_DOCKER_NoTransitionFromKillingToRunning (5264 ms)
[ RUN  ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS
[   OK ] DockerContainerizerTest.ROOT_DOCKER_DefaultDNS (5361 ms)
[--] 24 tests from DockerContainerizerTest (92361 ms total)

[--] 1 test from HungDockerTest
[ RUN  ] HungDockerTest.ROOT_DOCKER_InspectHungDuringPull

d:\dcos\mesos\mesos\src\tests\mock_docker.hpp(155): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @00FAA37BB830.
d:\dcos\mesos\mesos\src\tests\containerizer\docker_containerizer_tests.cpp(5187):
 ERROR: this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @00FAA37BBA90.
d:\dcos\mesos\mesos\src\tests\mock_docker.cpp(48): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @02A599888A00.
d:\dcos\mesos\mesos\src\tests\mock_registrar.cpp(54): ERROR: this mock object 
(used in test HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be 
deleted but never is. Its address is @02A59997FB60.
d:\dcos\mesos\mesos\3rdparty\libprocess\include\process\gmock.hpp(235): ERROR: 
this mock object (used in test 
HungDockerTest.ROOT_DOCKER_InspectHungDuringPull) should be deleted but never 
is. Its address is @02A599A0C9A8.
ERROR: 5 leaked mock objects found at program exit.
```

- 
[mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488/logs/mesos-tests-stderr.log):

```
I0704 13:10:32.687325  8732 authenticatee.cpp:299] Authentication success
I0704 13:10:32.687325 11612 master.cpp:9802] Successfully authenticated 
principal 'test-principal' at 
scheduler-b8095512-7ff4-4ce4-8203-4f44563ac3fb@192.10.1.6:62166
I0704 13:10:32.688321  8904 sched.cpp:501] Successfully authenticated with 
master master@192.10.1.6:62166
I0704 13:10:32.689339 11612 master.cpp:2927] Received SUBSCRIBE call for 
framework 'default' at 
scheduler-b8095512-7ff4-4ce4-8203-4f44563ac3fb@192.10.1.6:62166
I0704 13:10:32.689339 11612 master.cpp:2234] Authorizing framework principal 
'test-principal' to receive offers for roles '{ * }'
I0704 13:10:32.690328 10664 master.cpp:3008] Subscribing framework default with 
checkpointing disabled and capabilities [ MULTI_ROLE, RESERVATION_REFINEMENT ]
I0704 13:10:32.691329 10664 master.cpp:9993] Adding framework 
9ec3a217-3e46-43fd-8a0c-50b8c7a0ec87- (default) at 
scheduler-b8095512-7ff4-4ce4-8203-4f44563ac3fb@192.10.1.6:62166 with roles {  } 
suppressed
I0704 13:10:32.693317 10640 sched.cpp:749] Framework registered with 
9ec3a217-3e46-43fd-8a0c-50b8c7a0ec87-
I0704 13:10:32.693317  6292 hierarchical.cpp:299] Added framework 
9ec3a217-3e46-43fd-8a0c-50b8c7a0ec87-
E0704 13:10:32.786754  9368 slave.cpp:7289] EXIT with status 1: Failed to 
perform recovery: Collect failed: Failed to run 'C:\Program Files 
(x86)\Microsoft Visual Studio\2017\Community\VC\Auxiliary\Build\test-docker.bat 
-H npipe:./pipe/docker_engine ps -a': exited with status 1; 
stderr=''C:\Program' is

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-28 Thread Eric Chung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205559
---




src/python/cli_new/README.md
Line 11 (original), 11 (patched)


should we also include `tox` here?



src/python/cli_new/pip-requirements.txt
Line 11 (original), 11 (patched)


might be worthwhile to migrate to `pip-compile` and generate 
requirements.txt from requirements.in to avoid potential dependency conflicts


- Eric Chung


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake e2ee89a0be71488ea3b91bdb8270af03e83abac5 
>   configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 
>   src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/5/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-28 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205512
---



Patch looks great!

Reviews applied: [67411, 67412, 67413, 67487, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake e2ee89a0be71488ea3b91bdb8270af03e83abac5 
>   configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 
>   src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/5/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-28 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review205508
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake e2ee89a0be71488ea3b91bdb8270af03e83abac5 
>   configure.ac 8b8064aca7ae39e16dda40828b5a087b14b54a65 
>   src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/5/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-15 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204850
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/4/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-14 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204813
---



Patch looks great!

Reviews applied: [67411, 67412, 67413, 67487, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/3/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-14 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204782
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/3/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-13 Thread Mesos Reviewbot


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204742
---



Patch looks great!

Reviews applied: [67411, 67412, 67413, 67487, 67488]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-13 Thread Kevin Klues


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204685
---




src/python/cli_new/bootstrap
Lines 48-62 (original), 46-72 (patched)


Three is a better method of creating a virtualenv with python 3. Please see 
https://github.com/dcos/dcos-cli/blob/992d516cec5b7e21154190ae121c3c85b73baa17/python/bin/env.sh#L36
 for reference.



src/python/cli_new/lib/cli/tests/base.py
Lines 184-188 (original), 187-190 (patched)


Reverse the order of these.



src/python/cli_new/lib/cli/tests/base.py
Line 275 (original), 268-274 (patched)


Reverse this.



src/python/cli_new/lib/cli/tests/base.py
Lines 268-273 (patched)


Format similar to for Master with just 4 lines.



src/python/cli_new/lib/cli/tests/base.py
Lines 277-278 (original), 276-278 (patched)


Can you move this inside the try and have a finally that subtracts the 
Agent count? This may not work, because we return from the try, but it's worth 
a (sic) try.



src/python/cli_new/lib/cli/util.py
Lines 164-166 (original), 164-166 (patched)


Remove this comment


- Kevin Klues


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-13 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204670
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/2/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

2018-06-12 Thread Mesos Reviewbot Windows


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67488/#review204613
---



PASS: Mesos patch 67488 was successfully built and tested.

Reviews applied: `['67411', '67412', '67413', '67487', '67488']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67488

- Mesos Reviewbot Windows


On June 12, 2018, 4:29 p.m., Armand Grillet wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67488/
> ---
> 
> (Updated June 12, 2018, 4:29 p.m.)
> 
> 
> Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, Eric Chung, 
> and Kevin Klues.
> 
> 
> Bugs: MESOS-8955
> https://issues.apache.org/jira/browse/MESOS-8955
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The build tools are also up to date thus the CLI can still be built
> using Autotools and CMake. No features have been added to the CLI.
> 
> The PyInstaller dependency has been updated due to issues with
> PyInstaller 3.1.1 and Python 3.6.
> 
> 
> Diffs
> -
> 
>   cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d 
>   configure.ac f5a9d5bded40d2af6df7fe872395b076cbd37123 
>   src/Makefile.am 2bcee1e0e198e6be009174570cdaa1c8b8372a71 
>   src/python/cli_new/CMakeLists.txt ef8da70757e2721f4ac1bee46d0b5d95e81298ca 
>   src/python/cli_new/README.md 3d646e91a8c7c72d4ee1b1180454e5f587295053 
>   src/python/cli_new/bin/main.py 53130383d8ca2ed40c97224b3a6e98aa6b6b107c 
>   src/python/cli_new/bootstrap fb6fbc449a970ccf960914ed910204f3984ea61f 
>   src/python/cli_new/lib/cli/config.py 
> 6f92622725d8a042a2a728fd38c977ac690ef6be 
>   src/python/cli_new/lib/cli/docopt.py 
> 86a4e9c74326fb80cc59487113f07358dd96960d 
>   src/python/cli_new/lib/cli/http.py 03d6031cb3273575f41d4d06d9a409f74488a16b 
>   src/python/cli_new/lib/cli/plugins/agent/main.py 
> 59280ece8ebd00bb96df3675b6356a26cc48a2c0 
>   src/python/cli_new/lib/cli/plugins/base.py 
> e01a7b2bc4d4cbabe706c8926913f43d2b4cf69c 
>   src/python/cli_new/lib/cli/plugins/task/main.py 
> cc6cff56c71262729a8870017bef2e97636abe5a 
>   src/python/cli_new/lib/cli/tests/base.py 
> 4ffa27ca95ddf6575fb0a844d6996890bed4d8c9 
>   src/python/cli_new/lib/cli/tests/tests.py 
> 79e1036f6d11c63884091fe43672607b03955c1a 
>   src/python/cli_new/lib/cli/util.py 307b22293a9c7199ad7088dfd0db6dff83a08ac8 
>   src/python/cli_new/pip-requirements.txt 
> aeb023325e838aa42f8d7418bb7f8293c3fa5614 
>   src/python/cli_new/tests/main.py acf2e0868555da0eb1c1cee7fb30b1e80783f1e1 
>   src/python/cli_new/tox.ini 58ca3807e3d6096296b4cd09a5cec32b32444d91 
> 
> 
> Diff: https://reviews.apache.org/r/67488/diff/1/
> 
> 
> Testing
> ---
> 
> Testing done on Fedora 25 with `python` being Python 2.7, `python3` being 
> Python 3.5 and `python36` being Python 3.6.
> 
> 
> For Autotools:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ PYTHON_3=python36 ../configure --enable-new-cli --disable-java
> $ make check
> ```
> 
> For CMake:
> 
> ```
> $ ./bootstrap
> $ mkdir build
> $ cd build
> $ cmake .. -DENABLE_NEW_CLI=1 -DPYTHON=python36
> $ cmake --build . -- -j16
> $ ./src/mesos
> Mesos CLI
> 
> Usage:
>   mesos (-h | --help)
>   mesos --version
>   mesos  [...]
> 
> Options:
>   -h --help  Show this screen.
>   --version  Show version info.
> 
> Commands:
>   agent   Interacts with the Mesos agents
>   config  Interacts with the Mesos CLI configuration file
>   taskInteracts with the tasks running in a Mesos cluster
> 
> See 'mesos help ' for more information on a specific command.
> $ cmake --build . --target tests -- -j16
> $ ctest -R CLI
> Test project /home/agrillet/apache-mesos/build
> Start 4: CLITests
> 1/1 Test #4: CLITests .   Passed3.63 sec
> 
> 100% tests passed, 0 tests failed out of 1
> ```
> 
> Checked that the the CLI tests were run, that the content of the directory 
> build/src/cli was as expected, and that build/src/mesos was correctly running.
> 
> 
> Thanks,
> 
> Armand Grillet
> 
>

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

Re: Review Request 67488: Updated CLI to Python 3.

30 matches

Site Navigation

Mail list logo

Footer information