Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Alexander Rukletsov]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review207655
---


Ship it!




Ship It!

- Alexander Rukletsov


On June 15, 2018, 12:45 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 15, 2018, 12:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Vinod Kone, 
> and Zhitao Li.
> 
> 
> Bugs: MESOS-9000
> https://issues.apache.org/jira/browse/MESOS-9000
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   include/mesos/v1/master/master.proto 
> 12f019d8d0902e212d4a3706fe2310b514d0d183 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204938
---



PASS: Mesos patch 67575 was successfully built and tested.

Reviews applied: `['67575']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67575

- Mesos Reviewbot Windows


On June 15, 2018, 12:45 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 15, 2018, 12:45 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Vinod Kone, 
> and Zhitao Li.
> 
> 
> Bugs: MESOS-9000
> https://issues.apache.org/jira/browse/MESOS-9000
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   include/mesos/v1/master/master.proto 
> 12f019d8d0902e212d4a3706fe2310b514d0d183 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/2/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Zhitao Li]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204840
---




include/mesos/master/master.proto
Lines 605-606 (original), 605-609 (patched)


Please also update comments in `include/mesos/v1/master/master.proto`



include/mesos/master/master.proto
Lines 606 (patched)


```
// This is the latest state of the task according to the agent,
// which can be more recent...
```


- Zhitao Li


On June 15, 2018, 5:45 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 15, 2018, 5:45 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov, Anand Mazumdar, Vinod Kone, 
> and Zhitao Li.
> 
> 
> Bugs: MESOS-9000
> https://issues.apache.org/jira/browse/MESOS-9000
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204745
---



Bad review!

Reviews applied: []

Error:
No reviewers specified. Please find a reviewer by asking on JIRA or the mailing 
list.

- Mesos Reviewbot


On June 13, 2018, 4:37 p.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 13, 2018, 4:37 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>

Re: Review Request 67575: Changed operator API to notify subscribers on every status change.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67575/#review204716
---



PASS: Mesos patch 67575 was successfully built and tested.

Reviews applied: `['67575']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67575

- Mesos Reviewbot Windows


On June 13, 2018, 9:37 a.m., Benno Evers wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67575/
> ---
> 
> (Updated June 13, 2018, 9:37 a.m.)
> 
> 
> Review request for mesos.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Prior to this change, the master would only send TaskUpdated messages
> to subscribers when the latest known task state on the agent changed.
> 
> This implied that schedulers could not reliably wait for the status
> information corresponding to specific state updates (i.e. TASK_RUNNING),
> since there is no guarantee that subscribers get notified during
> the time when this status update will be included in the status field.
> 
> After this change, TaskUpdate messages are sent whenever the latest
> acknowledged state of the task changes.
> 
> 
> Diffs
> -
> 
>   include/mesos/master/master.proto 54f84120728eea7995422b9c356ed67e5b054623 
>   src/master/master.cpp 5db5a8da85f02323a5654c93ac47ec4aa7e711d2 
> 
> 
> Diff: https://reviews.apache.org/r/67575/diff/1/
> 
> 
> Testing
> ---
> 
> `make check`
> 
> 
> Thanks,
> 
> Benno Evers
> 
>