Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/
---

(Updated July 11, 2018, 11:23 a.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.


Repository: mesos


Description
---

Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.

Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.

The Windows instructions were updated to remove the note about setting
autocrlf globally, and the outdated note to use Python 2 was updated
while we were in the file.


Diffs
-

  .gitattributes PRE-CREATION 
  docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
  site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 


Diff: https://reviews.apache.org/r/67730/diff/3/


Testing (updated)
---

This RR is the test since it'll trigger the currently broken review bot.

Also see https://git-scm.com/docs/gitattributes

I created a new repo, set git config core.autocrlf false, added Mesos as a 
remote, checked out, and verified that the build failed with the GNU Patch 
assertion due to line-endings. I then applied this patch and did a hard reset, 
and veriried that the build worked correctly. So this is good to go, I think. 
Any objections?


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205964
---



Bad patch!

Reviews applied: [67730]

Failed command: python support/apply-reviews.py -n -r 67730

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-07-11 11:42:50 URL:https://reviews.apache.org/r/67730/diff/raw/ 
[2606/2606] -> "67730.patch" [1]
67730.patch:38: trailing whitespace.
Apache Mesos is a cluster manager that provides efficient 
resource isolation 
67730.patch:44: trailing whitespace.
Apache Mesos is a cluster manager that provides efficient 
resource isolation 
67730.patch:45: trailing whitespace.
and sharing across distributed applications, or frameworks. It can run Hadoop, 
67730.patch:46: trailing whitespace.
MPI, Hypertable, Spark, and other frameworks on a dynamically shared pool of 
error: patch failed: site/doap.rdf:27
error: site/doap.rdf: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22880/console

- Mesos Reviewbot


On July 10, 2018, 7:32 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated July 10, 2018, 7:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/3/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Till Toenshoff via Review Board]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205939
---


Ship it!




Ship It!

- Till Toenshoff


On July 10, 2018, 5:32 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated July 10, 2018, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/3/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205928
---



PASS: Mesos patch 67730 was successfully built and tested.

Reviews applied: `['67730']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/1896/mesos-review-67730

- Mesos Reviewbot Windows


On July 10, 2018, 5:32 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated July 10, 2018, 5:32 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/3/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/
---

(Updated July 10, 2018, 10:32 a.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.


Changes
---

Rebased.


Repository: mesos


Description
---

Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.

Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.

The Windows instructions were updated to remove the note about setting
autocrlf globally, and the outdated note to use Python 2 was updated
while we were in the file.


Diffs (updated)
-

  .gitattributes PRE-CREATION 
  docs/windows.md 86b9fe31b2036060c6fbfb080fc7981a943759bb 
  site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 


Diff: https://reviews.apache.org/r/67730/diff/3/

Changes: https://reviews.apache.org/r/67730/diff/2-3/


Testing
---

This RR is the test since it'll trigger the currently broken review bot.

Also see https://git-scm.com/docs/gitattributes


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205920
---




site/doap.rdf
Line 58 (original), 58 (patched)


This file has existing whitespace problems, want me to trim line endings?


- Andrew Schwartzmeyer


On June 25, 2018, 1:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 1:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205919
---



I created a new repo, set `git config core.autocrlf false`, added Mesos as a 
remote, checked out, and verified that the build failed with the GNU Patch 
assertion due to line-endings. I then applied this patch and did a hard reset, 
and veriried that the build worked correctly. So this is good to go, I think. 
Any objections?


.gitattributes
Lines 4-5 (patched)


This is probably overkill, but it's explicit.


- Andrew Schwartzmeyer


On June 25, 2018, 1:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 1:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Till Toenshoff]

> On June 25, 2018, 11:26 p.m., Till Toenshoff wrote:
> > Given that the problem triggering change on the CI got reverted, can we 
> > cann this review?
> 
> Andrew Schwartzmeyer wrote:
> I think we'll still want this as it will enable us to avoid this problem 
> entirely in the future. Simply put, Mesos on Windows will fail to build (with 
> a cryptic error) if this global Git configuration is set differently. 
> Unfortunately, other Git repos may require a different setting, so we should 
> not depend on a global configuration, but instead set it in our repo itself.

Makes sense - then let's get this to work :)


- Till


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205330
---


On June 25, 2018, 8:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 8:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

> On June 25, 2018, 1:44 p.m., Mesos Reviewbot Windows wrote:
> > FAIL: Some of the unit tests failed. Please check the relevant logs.
> > 
> > Reviews applied: `['67730']`
> > 
> > Failed command: `Start-MesosCITesting`
> > 
> > All the build artifacts available at: 
> > http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730
> > 
> > Relevant logs:
> > 
> > - 
> > [stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/stout-tests-cmake-stdout.log):
> > 
> > ```
> >"D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
> >(CustomBuild target) -> 
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
> > target) (1) ->
> >"D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) 
> > (3) ->
> >"D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
> > target) (1) ->
> >"D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) 
> > ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
> > target) (1) ->
> >"D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >"D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
> > target) (1) ->
> >"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) 
> > (14) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> > 1 Warning(s)
> > 5 Error(s)
> > 
> > Time Elapsed 00:03:16.35
> > ```
> > 
> > - 
> > [libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/libprocess-tests-cmake-stdout.log):
> > 
> > ```
> >(CustomBuild target) -> 
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]
> > 
> > 
> >
> > "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
> > (default target) (1) ->
> >"D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) 
> > (10) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]
> > 
> > 
> >
> > "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
> > (default target) (1) ->
> >"D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]
> > 
> > 
> >
> > "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
> > (default target) (1) ->
> >"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
> > (default target) (7) ->
> >"D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) 
> > (19) ->
> >  C:\Program Files (x86)\Microsoft Visual 
> > Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
> >  error MSB6006: "cmd.exe" exited with code 3. 
> > [D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]
> > 
> > 
> >
> > "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
> > (default target) (1) ->
> >"D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
> > (default target) (7) ->
> >"D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

> On June 25, 2018, 4:26 p.m., Till Toenshoff wrote:
> > Given that the problem triggering change on the CI got reverted, can we 
> > cann this review?

I think we'll still want this as it will enable us to avoid this problem 
entirely in the future. Simply put, Mesos on Windows will fail to build (with a 
cryptic error) if this global Git configuration is set differently. 
Unfortunately, other Git repos may require a different setting, so we should 
not depend on a global configuration, but instead set it in our repo itself.


- Andrew


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205330
---


On June 25, 2018, 1:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 1:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205342
---



Bad patch!

Reviews applied: [67730]

Failed command: python support/apply-reviews.py -n -r 67730

Error:
The support scripts will be upgraded to Python 3 by July 1st.
Make sure to install Python 3.6 on your machine before.
2018-06-26 03:48:07 URL:https://reviews.apache.org/r/67730/diff/raw/ 
[3035/3035] -> "67730.patch" [1]
67730.patch:48: trailing whitespace.
Apache Mesos is a cluster manager that provides efficient 
resource isolation 
67730.patch:54: trailing whitespace.
Apache Mesos is a cluster manager that provides efficient 
resource isolation 
67730.patch:55: trailing whitespace.
and sharing across distributed applications, or frameworks. It can run Hadoop, 
67730.patch:56: trailing whitespace.
MPI, Hypertable, Spark, and other frameworks on a dynamically shared pool of 
error: patch failed: site/doap.rdf:27
error: site/doap.rdf: patch does not apply

Full log: https://builds.apache.org/job/Mesos-Reviewbot/22796/console

- Mesos Reviewbot


On June 25, 2018, 8:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 8:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Till Toenshoff]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205330
---



Given that the problem triggering change on the CI got reverted, can we cann 
this review?

- Till Toenshoff


On June 25, 2018, 8:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 8:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205329
---



PASS: Mesos patch 67730 was successfully built and tested.

Reviews applied: `['67730']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730

- Mesos Reviewbot Windows


On June 26, 2018, 4:21 a.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 26, 2018, 4:21 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205327
---



Not sure why gitattributes isn't working :(

- Andrew Schwartzmeyer


On June 25, 2018, 1:21 p.m., Andrew Schwartzmeyer wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67730/
> ---
> 
> (Updated June 25, 2018, 1:21 p.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Instead of relying on the user to `core.autocrlf = true` before
> cloning, we now set this in `.gitattributes` for all files.
> 
> Only one file needed normalization via `git add --renormalize .`, it
> was `site/doap.rdf`.
> 
> The Windows instructions were updated to remove the note about setting
> autocrlf globally, and the outdated note to use Python 2 was updated
> while we were in the file.
> 
> 
> Diffs
> -
> 
>   .gitattributes PRE-CREATION 
>   docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
>   site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 
> 
> 
> Diff: https://reviews.apache.org/r/67730/diff/2/
> 
> 
> Testing
> ---
> 
> This RR is the test since it'll trigger the currently broken review bot.
> 
> Also see https://git-scm.com/docs/gitattributes
> 
> 
> Thanks,
> 
> Andrew Schwartzmeyer
> 
>

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205317
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67730']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/stout-tests-cmake-stdout.log):

```
   "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (10) ->
   (CustomBuild target) -> 
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
   "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (9) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (7) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

1 Warning(s)
5 Error(s)

Time Elapsed 00:03:16.35
```

- 
[libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/libprocess-tests-cmake-stdout.log):

```
   (CustomBuild target) -> 
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (10) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (4) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
(default target) (7) ->
   "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (19) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
(default target) (7) ->
   "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (22) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]

113 Warning(s)
5 Error(s)

Time Elapsed 00:03:35.51
```

-

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Andrew Schwartzmeyer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/
---

(Updated June 25, 2018, 1:21 p.m.)


Review request for mesos, Benjamin Bannier, Joseph Wu, and Till Toenshoff.


Changes
---

Explicitly set patch files as text.


Repository: mesos


Description
---

Instead of relying on the user to `core.autocrlf = true` before
cloning, we now set this in `.gitattributes` for all files.

Only one file needed normalization via `git add --renormalize .`, it
was `site/doap.rdf`.

The Windows instructions were updated to remove the note about setting
autocrlf globally, and the outdated note to use Python 2 was updated
while we were in the file.


Diffs (updated)
-

  .gitattributes PRE-CREATION 
  docs/windows.md 635c62c678e0a295d55aa958c75c7164c194399f 
  site/doap.rdf ce23184de617e4f4cd82018d5847561dd84a3865 


Diff: https://reviews.apache.org/r/67730/diff/2/

Changes: https://reviews.apache.org/r/67730/diff/1-2/


Testing
---

This RR is the test since it'll trigger the currently broken review bot.

Also see https://git-scm.com/docs/gitattributes


Thanks,

Andrew Schwartzmeyer

Re: Review Request 67730: Made Git normalize all line endings automatically.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67730/#review205313
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['67730']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730

Relevant logs:

- 
[stout-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/stout-tests-cmake-stdout.log):

```
   "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (7) ->
   (CustomBuild target) -> 
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\libarchive-3.3.2.vcxproj" (default target) (3) ->
   "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (4) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj" (default target) (6) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (5) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\stout\tests\stout-tests.vcxproj" (default 
target) (1) ->
   "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (14) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

1 Warning(s)
5 Error(s)

Time Elapsed 00:03:17.79
```

- 
[libprocess-tests-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67730/logs/libprocess-tests-cmake-stdout.log):

```
   (CustomBuild target) -> 
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\glog-da816ea70.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj" (default target) (7) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\bzip2-1.0.6.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj" (default target) (5) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\boost-1.65.0.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
(default target) (9) ->
   "D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj" (default target) (19) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\xz-5.2.3.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\benchmarks.vcxproj" 
(default target) (9) ->
   "D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj" (default target) (18) ->
 C:\Program Files (x86)\Microsoft Visual 
Studio\2017\Community\Common7\IDE\VC\VCTargets\Microsoft.CppCommon.targets(171,5):
 error MSB6006: "cmd.exe" exited with code 3. 
[D:\DCOS\mesos\3rdparty\protobuf-3.5.0.vcxproj]

113 Warning(s)
5 Error(s)

Time Elapsed 00:03:29.61
```

- 
[me