Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review212370 --- Ship it! Ship It! - Gilbert Song On Nov. 8, 2018, 7:24

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 19, 2019, 1:05 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 62-63 (patched) > > > > > > I would cache it and just parse the default profile once. Let's

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 19, 2019, 1:05 a.m., Gilbert Song wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 49 (patched) > > > > > > equivalent to `if(ret == -1 || EFAULT == errno)`?

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review212160 --- Fix it, then Ship it!

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 15, 2019, 11:02 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 17-18 (patched) > > > > > > A newline between. > > Andrei Budnik wrote: > >

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Jan. 15, 2019, 3:02 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 17-18 (patched) > > > > > > A newline between.

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review211985 --- Fix it, then Ship it!

Re: Review Request 68021: Added `linux/seccomp` isolator.

> On Dec. 29, 2018, 1:40 a.m., Qian Zhang wrote: > > src/slave/containerizer/mesos/isolators/linux/seccomp.cpp > > Lines 89-92 (patched) > > > > > > This is kind of strange to me, I think we do not have this kind of

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review211573 --- src/slave/containerizer/mesos/isolators/linux/seccomp.cpp Lines

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/#review211541 --- Fix it, then Ship it!

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/ --- (Updated Nov. 8, 2018, 3:24 p.m.) Review request for mesos, Gilbert Song, Jie

Re: Review Request 68021: Added `linux/seccomp` isolator.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68021/ --- (Updated Aug. 6, 2018, 1:39 p.m.) Review request for mesos, Gilbert Song, Jie