Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210677 --- Patch looks great! Reviews applied: [68131] Passed command: expo

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 616 (patched) > > > > > > Last time we tried running this benchmark, we discovered a dead-lock > > caused by the inte

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210632 --- PASS: Mesos patch 68131 was successfully built and tested. Review

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Line 640 (original), 674-677 (patched) > > > > > > I'm a bit confused by the intention behind the stop condition: > > >

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Nov. 18, 2018, 8:10 p.m.) Review request for mesos, Benno Evers and Be

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Nov. 6, 2018, 12:19 p.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 616 (patched) > > > > > > Last time we tried running this benchmark, we discovered a dead-lock > > caused by the inte

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210347 --- Fix it, then Ship it! src/tests/master_benchmarks.cpp Line 493

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210315 --- Patch looks great! Reviews applied: [68131] Passed command: expo

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review210314 --- PASS: Mesos patch 68131 was successfully built and tested. Review

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Nov. 4, 2018, 4:31 a.m.) Review request for mesos, Benno Evers and Ben

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review208210 --- Patch looks great! Reviews applied: [68131] Passed command: expo

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review208152 --- PASS: Mesos patch 68131 was successfully built and tested. Review

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 30, 2018, 8:47 p.m.) Review request for mesos, Benno Evers and Be

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review207116 --- PASS: Mesos patch 68131 was successfully built and tested. Review

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/#review207114 --- Patch looks great! Reviews applied: [68224, 68225, 68131] Passed

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Aug. 6, 2018, 11:40 a.m., Benno Evers wrote: > > src/tests/master_benchmarks.cpp > > Lines 496 (patched) > > > > > > Is it possible to store the last parameter directly as > > `process::Milliseconds`? Good ide

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

> On Aug. 8, 2018, 1:19 a.m., Benjamin Mahler wrote: > > src/tests/master_benchmarks.cpp > > Lines 512 (patched) > > > > > > The review summary needs to updated to reflect the renaming? Good catch! - Alexander -

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 9, 2018, 2:21 p.m.) Review request for mesos, Benno Evers and Ben

Re: Review Request 68131: Added MasterActorResponsiveness_BENCHMARK_Test.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68131/ --- (Updated Aug. 9, 2018, 2:15 p.m.) Review request for mesos, Benno Evers and Ben