Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68167/#review206817 --- FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68158', '68167']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167/logs/mesos-tests-stdout.log): ``` [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (32 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms) [--] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (70 ms total) [--] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (2011 ms) [--] 1 test from IsolationFlag/CpuIsolatorTest (2033 ms total) [--] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (1779 ms) [--] 1 test from IsolationFlag/MemoryIsolatorTest (1806 ms total) [--] Global test environment tear-down [==] 1013 tests from 98 test cases ran. (799762 ms total) [ PASSED ] 1010 tests. [ FAILED ] 3 tests, listed below: [ FAILED ] CommandExecutorCheckTest.CommandCheckTimeout [ FAILED ] DockerTest.ROOT_DOCKER_interface [ FAILED ] DockerTest.ROOT_DOCKER_CheckPortResource 3 FAILED TESTS YOU HAVE 222 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2032/mesos-review-68167/logs/mesos-tests-stderr.log): ``` I0802 18:32:12.731986 12504 master.cpp:10906] Updating the state of task cd7d2bc7-2973-434f-989e-f067e41d57e1 of framework 65cbebef-ae96-47ce-a4b1-9a26d7b085ae- (latest state: TASK_KILLED, status update state: TASK_KILLED) I0802 18:32:12.731986 14728 slave.cpp:3939] Shutting down framework 65cbebef-ae96-47ce-a4b1-9a26d7b085ae- I0802 18:32:12.731986 14728 slave.cpp:6658] Shutting down executor 'cd7d2bc7-2973-434f-989e-f067e41d57e1' of framework 65cbebef-ae96-47ce-a4b1-9a26d7b085ae- at executor(1)@192.10.1.6:50974 I0802 18:32:12.732987 14728 slave.cpp:931] Agent terminating W0802 18:32:12.734993 14728 slave.cpp:3935] Ignoring shutdown framework 65I0802 18:32:12.343991 9552 exec.cpp:162] Version: 1.7.0 I0802 18:32:12.369982 2088 exec.cpp:236] Executor registered on agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 I0802 18:32:12.373984 9828 executor.cpp:182] Received SUBSCRIBED event I0802 18:32:12.378980 9828 executor.cpp:186] Subscribed executor on windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net I0802 18:32:12.378980 9828 executor.cpp:182] Received LAUNCH event I0802 18:32:12.383980 9828 executor.cpp:679] Starting task cd7d2bc7-2973-434f-989e-f067e41d57e1 I0802 18:32:12.470983 9828 executor.cpp:499] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch ' I0802 18:32:12.703992 9828 executor.cpp:693] Forked command at 3452 I0802 18:32:12.734823 3712 exec.cpp:445] Executor asked to shutdown I0802 18:32:12.734993 9828 executor.cpp:182] Received SHUTDOWN event I0802 18:32:12.734993 9828 executor.cpp:796] Shutting down I0802 18:32:12.734993 9828 executor.cpp:909] Sending SIGTERM to process tree at pid 345cbebef-ae96-47ce-a4b1-9a26d7b085ae- because it is terminating I0802 18:32:12.734993 12504 master.cpp:11004] Removing task cd7d2bc7-2973-434f-989e-f067e41d57e1 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework 65cbebef-ae96-47ce-a4b1-9a26d7b085ae- on agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0802 18:32:12.737992 12504 master.cpp:1281] Agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected I0802 18:32:12.737992 12504 master.cpp:3297] Disconnecting agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249 (windows-02.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0802 18:32:12.738987 12504 master.cpp:3316] Deactivating agent 65cbebef-ae96-47ce-a4b1-9a26d7b085ae-S0 at slave(462)@192.10.1.6:49249
Re: Review Request 68167: Avoided hostname lookups in the CNI port mapper.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68167/#review206806 --- Ship it! Ship It! - Jie Yu On Aug. 2, 2018, 4:30 p.m., Greg Mann wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68167/ > --- > > (Updated Aug. 2, 2018, 4:30 p.m.) > > > Review request for mesos and Jie Yu. > > > Bugs: MESOS-9129 > https://issues.apache.org/jira/browse/MESOS-9129 > > > Repository: mesos > > > Description > --- > > Using the `-n` option with `iptables --list` prevents potentially > costly reverse hostname lookups. This patch adds this option to the > relevant invocation of `iptables` in the CNI port mapper. > > > Diffs > - > > > src/slave/containerizer/mesos/isolators/network/cni/plugins/port_mapper/port_mapper.cpp > c40b57f78193520f9f0b901201b5c4c855cde8b3 > > > Diff: https://reviews.apache.org/r/68167/diff/1/ > > > Testing > --- > > > Thanks, > > Greg Mann > >
