Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-14 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review207271
---


Ship it!




Ship It!

- Gilbert Song


On Aug. 13, 2018, 11:29 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68222/
> ---
> 
> (Updated Aug. 13, 2018, 11:29 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 2 tests for `docker/volume` isolator to cover read-only volume.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> c15a6fad642474765e4ad1952af6cd9ee937379e 
> 
> 
> Diff: https://reviews.apache.org/r/68222/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-14 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review207222
---



PASS: Mesos patch 68222 was successfully built and tested.

Reviews applied: `['68212', '68213', '68214', '68215', '68216', '68218', 
'68219', '68220', '68221', '68222']`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2147/mesos-review-68222

- Mesos Reviewbot Windows


On Aug. 14, 2018, 8:29 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68222/
> ---
> 
> (Updated Aug. 14, 2018, 8:29 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 2 tests for `docker/volume` isolator to cover read-only volume.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> c15a6fad642474765e4ad1952af6cd9ee937379e 
> 
> 
> Diff: https://reviews.apache.org/r/68222/diff/3/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-14 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

(Updated Aug. 14, 2018, 2:29 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Addressed review comments.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/3/

Changes: https://reviews.apache.org/r/68222/diff/2-3/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-13 Thread Gilbert Song 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review207193
---




src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1175-1179 (patched)


why do we have 1 here?



src/tests/containerizer/docker_volume_isolator_tests.cpp
Lines 1307-1311 (patched)


ditto.


- Gilbert Song


On Aug. 7, 2018, 7:24 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68222/
> ---
> 
> (Updated Aug. 7, 2018, 7:24 a.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 2 tests for `docker/volume` isolator to cover read-only volume.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> c15a6fad642474765e4ad1952af6cd9ee937379e 
> 
> 
> Diff: https://reviews.apache.org/r/68222/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-08 Thread Mesos Reviewbot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review206971
---



Patch looks great!

Reviews applied: [68212, 68213, 68214, 68215, 68216, 68218, 68219, 68220, 
68221, 68222]

Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' 
CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 
MESOS_VERBOSE=1'; ./support/docker-build.sh

- Mesos Reviewbot


On Aug. 7, 2018, 2:24 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68222/
> ---
> 
> (Updated Aug. 7, 2018, 2:24 p.m.)
> 
> 
> Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.
> 
> 
> Bugs: MESOS-8814
> https://issues.apache.org/jira/browse/MESOS-8814
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added 2 tests for `docker/volume` isolator to cover read-only volume.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_volume_isolator_tests.cpp 
> c15a6fad642474765e4ad1952af6cd9ee937379e 
> 
> 
> Diff: https://reviews.apache.org/r/68222/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-07 Thread Mesos Reviewbot Windows 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/#review206949
---



FAIL: Some of the unit tests failed. Please check the relevant logs.

Reviews applied: `['68212', '68213', '68214', '68215', '68216', '68218', 
'68219', '68220', '68221', '68222']`

Failed command: `Start-MesosCITesting`

All the build artifacts available at: 
http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2114/mesos-review-68222

Relevant logs:

- 
[libprocess-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2114/mesos-review-68222/logs/libprocess-tests-cmake.log):

```
 
d:\dcos\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2\http_parser.c(2401):
 warning C4244: '=': conversion from '__int64' to 'uint16_t', possible loss of 
data 
[D:\DCOS\mesos\3rdparty\http_parser-2.6.2\src\http_parser-2.6.2-build\http_parser.vcxproj]
 [D:\DCOS\mesos\3rdparty\http_parser-2.6.2.vcxproj]


   "D:\DCOS\mesos\3rdparty\libprocess\src\tests\libprocess-tests.vcxproj" 
(default target) (1) ->
   "D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj" (default target) (12) ->
 cmake -E tar : warning : skipping symbolic link 
"grpc-1.10.0/test/core/http/python_wrapper.sh" -> 
"../../../tools/distrib/python_wrapper.sh". 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\transport\bdp_estimator.cc(35):
 warning C4244: 'initializing': conversion from 'double' to 'int', possible 
loss of data 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 
d:\dcos\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0\src\core\lib\iomgr\error_internal.h(56):
 warning C4200: nonstandard extension used: zero-sized array in struct/union 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 create_channel_posix.obj : warning LNK4221: This object file does not 
define any previously undefined public symbols, so it will not be used by any 
link operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 server_posix.obj : warning LNK4221: This object file does not define 
any previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]
 rpc_method.obj : warning LNK4221: This object file does not define any 
previously undefined public symbols, so it will not be used by any link 
operation that consumes this library 
[D:\DCOS\mesos\3rdparty\grpc-1.10.0\src\grpc-1.10.0-build\grpc++_unsecure.vcxproj]
 [D:\DCOS\mesos\3rdparty\grpc-1.10.0.vcxproj]

Re: Review Request 68222: Added 2 tests for `docker/volume` isolator to cover read-only volume.

2018-08-07 Thread Qian Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68222/
---

(Updated Aug. 7, 2018, 10:24 p.m.)


Review request for mesos, Gilbert Song, Greg Mann, Ilya Pronin, and Jie Yu.


Changes
---

Rebased.


Bugs: MESOS-8814
https://issues.apache.org/jira/browse/MESOS-8814


Repository: mesos


Description
---

Added 2 tests for `docker/volume` isolator to cover read-only volume.


Diffs (updated)
-

  src/tests/containerizer/docker_volume_isolator_tests.cpp 
c15a6fad642474765e4ad1952af6cd9ee937379e 


Diff: https://reviews.apache.org/r/68222/diff/2/

Changes: https://reviews.apache.org/r/68222/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang