Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review210411
---


Ship it!




Ship It!

- Gilbert Song


On Oct. 14, 2018, 7:12 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68646/
> ---
> 
> (Updated Oct. 14, 2018, 7:12 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9164
> https://issues.apache.org/jira/browse/MESOS-9164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated launchers to use subprocess's `whitelist_fds` parameter.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> a18bdff6b64f978b87af16c2655d07ba8553bc95 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> e9ab36a16b24a123a660506d55f16dea16dee911 
> 
> 
> Diff: https://reviews.apache.org/r/68646/diff/2/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

[Qian Zhang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/
---

(Updated Oct. 14, 2018, 10:12 p.m.)


Review request for mesos, Gilbert Song and James Peach.


Bugs: MESOS-9164
https://issues.apache.org/jira/browse/MESOS-9164


Repository: mesos


Description
---

Updated launchers to use subprocess's `whitelist_fds` parameter.


Diffs (updated)
-

  src/slave/containerizer/mesos/launcher.cpp 
a18bdff6b64f978b87af16c2655d07ba8553bc95 
  src/slave/containerizer/mesos/linux_launcher.cpp 
e9ab36a16b24a123a660506d55f16dea16dee911 


Diff: https://reviews.apache.org/r/68646/diff/2/

Changes: https://reviews.apache.org/r/68646/diff/1-2/


Testing
---

sudo make check


Thanks,

Qian Zhang

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review209494
---


Fix it, then Ship it!





src/slave/containerizer/mesos/launcher.cpp
Line 130 (original)


Since you are fixing MESOS-9164 here as well, update the the "Bugs" field, 
and the corresponsing JIRA.


- James Peach


On Sept. 6, 2018, 1:25 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68646/
> ---
> 
> (Updated Sept. 6, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated launchers to use subprocess's `whitelist_fds` parameter.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> a18bdff6b64f978b87af16c2655d07ba8553bc95 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> e9ab36a16b24a123a660506d55f16dea16dee911 
> 
> 
> Diff: https://reviews.apache.org/r/68646/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 68646: Updated launchers to use subprocess's `whitelist_fds` parameter.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68646/#review208394
---



PASS: Mesos patch 68646 was successfully built and tested.

Reviews applied: `['68642', '68643', '68644', '68645', '68646']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2301/mesos-review-68646

- Mesos Reviewbot Windows


On Sept. 6, 2018, 1:25 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68646/
> ---
> 
> (Updated Sept. 6, 2018, 1:25 a.m.)
> 
> 
> Review request for mesos, Gilbert Song and James Peach.
> 
> 
> Bugs: MESOS-9152
> https://issues.apache.org/jira/browse/MESOS-9152
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated launchers to use subprocess's `whitelist_fds` parameter.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/launcher.cpp 
> a18bdff6b64f978b87af16c2655d07ba8553bc95 
>   src/slave/containerizer/mesos/linux_launcher.cpp 
> e9ab36a16b24a123a660506d55f16dea16dee911 
> 
> 
> Diff: https://reviews.apache.org/r/68646/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>