Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review210013 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 11:46 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 11:08 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209996 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 10:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209995 --- FAIL: Failed to apply the dependent review: 68956. Failed

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 24, 2018, 9:38 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 23, 2018, 11:42 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 667 (patched) > > > > > > This should be in alphabetical order. Fixed. - Jacob

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209939 --- Fix it, then Ship it! docs/configuration/master.md Lines 667

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209907 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 11:53 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 11:42 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209905 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 22, 2018, 4:45 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 669 (patched) > > > > > > Since this is a boolean flag, it should be: > > ``` > >

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 22, 2018, 10:05 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

> On Oct. 22, 2018, 4:42 p.m., James Peach wrote: > > docs/configuration/master.md > > Lines 672 (patched) > > > > > > I think that we should give the operator a bit more context here. Maybe > > something like

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209877 --- docs/configuration/master.md Lines 669 (patched)

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209876 --- docs/configuration/master.md Lines 672 (patched)

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209781 --- Patch looks great! Reviews applied: [68953, 68956, 68957]

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209770 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 18, 2018, 10:59 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209730 --- Bad patch! Reviews applied: [68957, 68956, 68953] Failed

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209723 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 17, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209472 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 11, 2018, 11:17 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 11, 2018, 11:14 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209445 --- Patch looks great! Reviews applied: [68953, 68954, 68955, 68956,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209423 --- PASS: Mesos patch 68957 was successfully built and tested.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 10, 2018, 10:19 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/ --- (Updated Oct. 10, 2018, 9:55 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209344 --- Bad review! Reviews applied: [] Error: No reviewers specified.

Re: Review Request 68957: Add documentation for per-framework metrics flag.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68957/#review209339 --- FAIL: Some of the unit tests failed. Please check the relevant