Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210238 --- PASS: Mesos patch 69010 was successfully built and tested. All

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 31, 2018, 6:21 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210216 --- Patch looks great! Reviews applied: [69009, 69085, 69010]

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review210200 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 30, 2018, 9:08 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209982 --- Ship it! Ship It! - Benjamin Bannier On Oct. 18, 2018, 4:01

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209800 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209733 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 18, 2018, 2:01 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209720 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209715 --- Patch looks great! Reviews applied: [69009, 69010] Passed

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 17, 2018, 8:30 p.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 4:21 p.m., Benjamin Bannier wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > I agree with James here. It seems totally fine to me to _always `sync`_ > > here.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209691 --- Fix it, then Ship it!

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209597 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 16, 2018, 4:46 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > I agree with James here. It seems totally fine to me to _always `sync`_ > > here.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 13, 2018, 2:49 a.m., James DeFelice wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > Why is the default `false` here? If someone is calling the `checkpoint` > > func

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209586 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > I agree with James here. It seems totally fine to me to _always `sync`_ > > here.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1158-1171 (patched) > > > > > > Since the connection of this to the surrounding could is not > >

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 16, 2018, 2:48 a.m.) Review request for mesos, Benjamin Bannier,

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209579 --- PASS: Mesos patch 69010 was successfully built and tested.

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/ --- (Updated Oct. 15, 2018, 10:08 p.m.) Review request for mesos, Benjamin

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209565 --- Patch looks great! Reviews applied: [69009, 69010] Passed

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 15, 2018, 2:21 p.m., Benjamin Bannier wrote: > > src/resource_provider/storage/provider.cpp > > Lines 1158-1171 (patched) > > > > > > Since the connection of this to the surrounding could is not > >

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209542 --- src/resource_provider/storage/provider.cpp Line 663 (original),

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

> On Oct. 13, 2018, 2:49 a.m., James DeFelice wrote: > > src/slave/state.hpp > > Line 192 (original), 196 (patched) > > > > > > Why is the default `false` here? If someone is calling the `checkpoint` > > func

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209512 --- src/slave/state.hpp Line 192 (original), 196 (patched)

Re: Review Request 69010: Synced SLRP checkpoints to the filesystem.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69010/#review209508 --- FAIL: Some of the unit tests failed. Please check the relevant