Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/
---

(Updated Nov. 2, 2018, 10:22 p.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Changes
---

Addressed James' and Benjamin's comments.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

The semantics of these two operations has been updated to provide
primitives to import CSI volumes and recover CSI volumes against agent
ID changes and metadata loss.


Diffs (updated)
-

  include/mesos/mesos.proto f6989cd5e7a47c3fec29bdeccc38474bf0045341 
  include/mesos/v1/mesos.proto edad35a928705f21aa1aca31f3e9cfd30810 


Diff: https://reviews.apache.org/r/69036/diff/5/

Changes: https://reviews.apache.org/r/69036/diff/4-5/


Testing
---

Test will be done later in the chain.


Thanks,

Chun-Hung Hsiao

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[James DeFelice]

> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 2030 (patched)
> > 
> >
> > Referring to an implementation artifact like the "disk profile adaptor" 
> > seems strange in this context. Perhaps re-word this?
> > 
> > Instead of:
> > > has been removed by the disk profile adaptor
> > 
> > Maybe something like this instead?
> > > is no longer known by Mesos
> 
> Chun-Hung Hsiao wrote:
> The "disk profile adaptor" is a public module interface in Mesos so I was 
> trying to be explicit. WDYT?

" the disk resource is no longer reported by the disk profile adapter." ?

the adapter interface just reports a matrix, right? it doesn't actually 
create/remove things.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review209920
---


On Oct. 23, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> ---
> 
> (Updated Oct. 23, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/4/
> 
> 
> Testing
> ---
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[Benjamin Bannier]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review210147
---



Partial review.

I still wonder whether we should mention CSI in these interfaces at all; I am 
not sure it adds much.


include/mesos/mesos.proto
Lines 2016-2017 (patched)


Let's change emphasis here to mention that _frameworks should make sure 
this is valid or we'd reject the operation_.


- Benjamin Bannier


On Oct. 23, 2018, 4:37 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> ---
> 
> (Updated Oct. 23, 2018, 4:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/4/
> 
> 
> Testing
> ---
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[Chun-Hung Hsiao]

> On Oct. 23, 2018, 2:51 p.m., James DeFelice wrote:
> > include/mesos/mesos.proto
> > Lines 2030 (patched)
> > 
> >
> > Referring to an implementation artifact like the "disk profile adaptor" 
> > seems strange in this context. Perhaps re-word this?
> > 
> > Instead of:
> > > has been removed by the disk profile adaptor
> > 
> > Maybe something like this instead?
> > > is no longer known by Mesos

The "disk profile adaptor" is a public module interface in Mesos so I was 
trying to be explicit. WDYT?


- Chun-Hung


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review209920
---


On Oct. 23, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> ---
> 
> (Updated Oct. 23, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/4/
> 
> 
> Testing
> ---
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[James DeFelice]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/#review209920
---




include/mesos/mesos.proto
Lines 2030 (patched)


Referring to an implementation artifact like the "disk profile adaptor" 
seems strange in this context. Perhaps re-word this?

Instead of:
> has been removed by the disk profile adaptor

Maybe something like this instead?
> is no longer known by Mesos


- James DeFelice


On Oct. 23, 2018, 2:37 a.m., Chun-Hung Hsiao wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69036/
> ---
> 
> (Updated Oct. 23, 2018, 2:37 a.m.)
> 
> 
> Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.
> 
> 
> Bugs: MESOS-9275
> https://issues.apache.org/jira/browse/MESOS-9275
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> The semantics of these two operations has been updated to provide
> primitives to import CSI volumes and recover CSI volumes against agent
> ID changes and metadata loss.
> 
> 
> Diffs
> -
> 
>   include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
>   include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 
> 
> 
> Diff: https://reviews.apache.org/r/69036/diff/4/
> 
> 
> Testing
> ---
> 
> Test will be done later in the chain.
> 
> 
> Thanks,
> 
> Chun-Hung Hsiao
> 
>

Re: Review Request 69036: WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.

[Chun-Hung Hsiao]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69036/
---

(Updated Oct. 23, 2018, 2:37 a.m.)


Review request for mesos, Benjamin Bannier, James DeFelice, and Jie Yu.


Changes
---

Renamed `CreateDisk.profile` to `CreateDisk.target_profile`.


Summary (updated)
-

WIP: Changed the semantics of `CREATE_DISK` and `DESTROY_DISK` operations.


Bugs: MESOS-9275
https://issues.apache.org/jira/browse/MESOS-9275


Repository: mesos


Description
---

The semantics of these two operations has been updated to provide
primitives to import CSI volumes and recover CSI volumes against agent
ID changes and metadata loss.


Diffs (updated)
-

  include/mesos/mesos.proto 5a985fca39cdfb7e9b4775650a7e5dbe68c3b8ae 
  include/mesos/v1/mesos.proto a5ebb786a98bd3fd34745ddc553aa7a751c0e337 


Diff: https://reviews.apache.org/r/69036/diff/4/

Changes: https://reviews.apache.org/r/69036/diff/3-4/


Testing
---

Test will be done later in the chain.


Thanks,

Chun-Hung Hsiao