subject:"Re\: Review Request 69541\: Added volume gid manager."

Re: Review Request 69541: Added volume gid manager.

2019-01-06 Thread Qian Zhang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Jan. 7, 2019, 8:26 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-20 Thread Qian Zhang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 21, 2018, 10:57 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-19 Thread Qian Zhang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 20, 2018, 9:35 a.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-18 Thread Andrei Budnik

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/#review211408 --- Fix it, then Ship it! Ship It!

Re: Review Request 69541: Added volume gid manager.

2018-12-18 Thread Qian Zhang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 18, 2018, 4:11 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-14 Thread Qian Zhang

> On Dec. 13, 2018, 8:36 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp > > Lines 100 (patched) > > > > > > I have a small concern regarding unconditionally

Re: Review Request 69541: Added volume gid manager.

2018-12-13 Thread Andrei Budnik

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/#review211282 ---

Re: Review Request 69541: Added volume gid manager.

2018-12-13 Thread Qian Zhang

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69541/ --- (Updated Dec. 13, 2018, 7:46 p.m.) Review request for mesos, Andrei Budnik,

Re: Review Request 69541: Added volume gid manager.

2018-12-13 Thread Qian Zhang

> On Dec. 11, 2018, 10:02 p.m., Andrei Budnik wrote: > > src/slave/containerizer/mesos/volume_gid_manager/volume_gid_manager.cpp > > Lines 180 (patched) > > > > > > Suggestion: we could also pass `containerId` to