Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review213692 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review213473 --- Patch looks great! Reviews applied: [69615] Passed command:

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ --- (Updated March 6, 2019, 1:08 a.m.) Review request for mesos, Xudong Ni,

Re: Review Request 69615: Disable containerizer ptrace attach.

> On Feb. 14, 2019, 7:07 a.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 556 (patched) > > > > > > The main thing I wanted to confirm is what we chatted about offline but > > I

Re: Review Request 69615: Disable containerizer ptrace attach.

> On Feb. 13, 2019, 11:07 p.m., Jiang Yan Xu wrote: > > src/slave/containerizer/mesos/launch.cpp > > Lines 556 (patched) > > > > > > The main thing I wanted to confirm is what we chatted about offline but > > I

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212930 --- Bad review! Reviews applied: [69615] Error: 2019-02-19 22:06:02

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212878 --- FAIL: Failed to apply the current review. Failed command:

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212822 --- src/slave/containerizer/mesos/launch.cpp Lines 556 (patched)

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review212680 --- PASS: Mesos patch 69615 was successfully built and tested.

Re: Review Request 69615: Disable containerizer ptrace attach.

> On Jan. 18, 2019, 8:36 a.m., Jiang Yan Xu wrote: > > src/slave/flags.cpp > > Lines 338 (patched) > > > > > > If disallow is the default, it's a breaking change right? Can the > > default be allowing it? Strictly

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ --- (Updated Feb. 8, 2019, 9:09 p.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211839 --- For consistency if we updated command excutor we should update

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211831 --- src/slave/slave.cpp Lines 6183 (patched)

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211786 --- FAIL: Some of the unit tests failed. Please check the relevant

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211735 --- Ship it! Ship It! - Xudong Ni On Jan. 2, 2019, 5:15 p.m.,

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/ --- (Updated Jan. 2, 2019, 5:15 p.m.) Review request for mesos, Xudong Ni, Gilbert

Re: Review Request 69615: Disable containerizer ptrace attach.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69615/#review211517 --- src/slave/containerizer/mesos/launch.cpp Lines 142 (patched)