Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69717/#review211904
---


Fix it, then Ship it!





src/tests/slave_recovery_tests.cpp
Lines 2925 (patched)


Why do we need ` ;)` in the new bootID?


- Gilbert Song


On Jan. 11, 2019, 12:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69717/
> ---
> 
> (Updated Jan. 11, 2019, 12:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-9501
> https://issues.apache.org/jira/browse/MESOS-9501
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 
> 
> 
> Diff: https://reviews.apache.org/r/69717/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> And I verified this test will fail without the patch: 
> https://reviews.apache.org/r/69705/
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

[Andrei Budnik]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69717/#review211884
---


Ship it!




Ship It!

- Andrei Budnik


On Jan. 11, 2019, 8:01 a.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69717/
> ---
> 
> (Updated Jan. 11, 2019, 8:01 a.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-9501
> https://issues.apache.org/jira/browse/MESOS-9501
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 
> 
> 
> Diff: https://reviews.apache.org/r/69717/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> And I verified this test will fail without the patch: 
> https://reviews.apache.org/r/69705/
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>

Re: Review Request 69717: Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69717/#review211872
---



PASS: Mesos patch 69717 was successfully built and tested.

Reviews applied: `['69705', '69716', '69717']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2757/mesos-review-69717

- Mesos Reviewbot Windows


On Jan. 11, 2019, 4:01 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69717/
> ---
> 
> (Updated Jan. 11, 2019, 4:01 p.m.)
> 
> 
> Review request for mesos, Andrei Budnik, Gilbert Song, and Vinod Kone.
> 
> 
> Bugs: MESOS-9501
> https://issues.apache.org/jira/browse/MESOS-9501
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added a test `SlaveRecoveryTest.RebootWithExecutorPidReused`.
> 
> 
> Diffs
> -
> 
>   src/tests/slave_recovery_tests.cpp 0eb47e2bdf6a46fc21b59bb85b4b89181087ccd3 
> 
> 
> Diff: https://reviews.apache.org/r/69717/diff/1/
> 
> 
> Testing
> ---
> 
> sudo make check
> 
> And I verified this test will fail without the patch: 
> https://reviews.apache.org/r/69705/
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>