Re: Review Request 69880: Added header comments for two master methods.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69880/
---

(Updated Feb. 12, 2019, 9:38 p.m.)


Review request for mesos, Gastón Kleiman, Joseph Wu, and Vinod Kone.


Repository: mesos


Description
---

Added header comments for two master methods.


Diffs
-

  src/master/master.hpp 75f396a8dbf2046b76801ca044b62ac386f255df 


Diff: https://reviews.apache.org/r/69880/diff/2/


Testing
---


Thanks,

Greg Mann

Re: Review Request 69880: Added header comments for two master methods.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69880/#review212537
---



PASS: Mesos patch 69880 was successfully built and tested.

Reviews applied: `['69876', '69880']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2848/mesos-review-69880

- Mesos Reviewbot Windows


On Feb. 4, 2019, 9:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69880/
> ---
> 
> (Updated Feb. 4, 2019, 9:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added header comments for two master methods.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 75f396a8dbf2046b76801ca044b62ac386f255df 
> 
> 
> Diff: https://reviews.apache.org/r/69880/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 69880: Added header comments for two master methods.

[Gastón Kleiman]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69880/#review212532
---


Fix it, then Ship it!





src/master/master.hpp
Lines 665 (patched)


Looking at 
https://github.com/apache/mesos/blob/9f6ccbd41a55846e54297ecb31fddbeee3be50c9/src/master/master.cpp#L6851-L6865
 I think that this method will be called only if the agent tries to register 
using an already known PID (IP + port).

`Master::_registerSlave()` has a comment with a bit more detail:

```
  // The slave was previously disconnected but it is now trying
  // to register as a new slave.
  // There are several possible reasons for this to happen:
  // - If the slave failed recovery and hence registering as a new
  //   slave before the master removed the old slave from its map.
  // - If the slave was shutting down while it had a registration
  //   retry scheduled. See MESOS-8463.
```


- Gastón Kleiman


On Feb. 4, 2019, 1:41 p.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69880/
> ---
> 
> (Updated Feb. 4, 2019, 1:41 p.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added header comments for two master methods.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 75f396a8dbf2046b76801ca044b62ac386f255df 
> 
> 
> Diff: https://reviews.apache.org/r/69880/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>

Re: Review Request 69880: Added header comments for two master methods.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69880/
---

(Updated Feb. 4, 2019, 9:41 p.m.)


Review request for mesos, Gastón Kleiman, Joseph Wu, and Vinod Kone.


Repository: mesos


Description
---

Added header comments for two master methods.


Diffs
-

  src/master/master.hpp 75f396a8dbf2046b76801ca044b62ac386f255df 


Diff: https://reviews.apache.org/r/69880/diff/1/


Testing
---


Thanks,

Greg Mann

Re: Review Request 69880: Added header comments for two master methods.

[Mesos Reviewbot Windows]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69880/#review212509
---



PASS: Mesos patch 69880 was successfully built and tested.

Reviews applied: `['69880']`

All the build artifacts available at: 
http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2843/mesos-review-69880

- Mesos Reviewbot Windows


On Feb. 2, 2019, 1:16 a.m., Greg Mann wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69880/
> ---
> 
> (Updated Feb. 2, 2019, 1:16 a.m.)
> 
> 
> Review request for mesos, Gastón Kleiman, Joseph Wu, and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added header comments for two master methods.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 75f396a8dbf2046b76801ca044b62ac386f255df 
> 
> 
> Diff: https://reviews.apache.org/r/69880/diff/1/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Greg Mann
> 
>