Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-06-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215654 --- Fix it, then Ship it!

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-23 Thread Meng Zhu
> On May 23, 2019, 4:23 a.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto > > Lines 149-150 (patched) > > > > > > I would like us to challenge the necessity of passing `QuotaConfig` > >

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-23 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215484 --- include/mesos/authorizer/authorizer.proto Line 139 (original),

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-22 Thread Meng Zhu
> On May 9, 2019, 6:43 a.m., Alexander Rukletsov wrote: > > include/mesos/authorizer/authorizer.proto > > Lines 138-140 (original), 139-144 (patched) > > > > > > If my understanding is correct, both `UPDATE_QUOTA`

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-22 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/ --- (Updated May 22, 2019, 5:48 a.m.) Review request for mesos, Alexander

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-09 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215160 --- include/mesos/authorizer/authorizer.proto Lines 138-140

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-06 Thread Meng Zhu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/ --- (Updated May 6, 2019, 4 p.m.) Review request for mesos, Andrei Sekretenko and

Re: Review Request 70549: Added authorization for `UpdateQuota` call in the master.

2019-05-06 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70549/#review215073 --- include/mesos/authorizer/authorizer.proto Lines 142-143