Re: Review Request 70801: Refactored allocator with the new quota wrapper struct.

[Benjamin Mahler]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70801/#review215815
---


Ship it!





src/master/allocator/mesos/hierarchical.cpp
Line 1413 (original), 1413 (patched)


We should probably think through the setting semantics when we do the 
wiring, because this seems to suggest that something is stopping the caller 
from setting to the default? (otherwise the remove / set semantics here won't 
quite hold)



src/master/allocator/mesos/hierarchical.cpp
Line 1450 (original), 1441 (patched)


Ditto here, seems to imply that something is stopping the caller from 
setting to default, perhaps a note about this (i.e. it's impossible to set to 
default using the old API).



src/master/constants.hpp
Lines 176 (patched)


How about: "quota: no guarantees ..."



src/master/allocator/mesos/hierarchical.cpp
Line 2571 (original), 2551 (patched)


Is this done frequently? If so, consider avoiding the double lookup


- Benjamin Mahler


On June 11, 2019, 8:15 p.m., Meng Zhu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70801/
> ---
> 
> (Updated June 11, 2019, 8:15 p.m.)
> 
> 
> Review request for mesos and Benjamin Mahler.
> 
> 
> Bugs: MESOS-9807
> https://issues.apache.org/jira/browse/MESOS-9807
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch also introduces a constant `DEFAULT_QUOTA`.
> By default, a role has no guarantees and no limits.
> 
> 
> Diffs
> -
> 
>   src/master/allocator/mesos/hierarchical.hpp 
> 1a3329d0e50ad2adb6aeadcd5d315eb572a85704 
>   src/master/allocator/mesos/hierarchical.cpp 
> ad0bcca90dcce4c9e8384293181c4f4af3d274aa 
>   src/master/constants.hpp 8f729d18ec3678d97efbb74a8e816348c6acbeb4 
> 
> 
> Diff: https://reviews.apache.org/r/70801/diff/2/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Meng Zhu
> 
>

Re: Review Request 70801: Refactored allocator with the new quota wrapper struct.

[Meng Zhu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70801/
---

(Updated June 11, 2019, 1:15 p.m.)


Review request for mesos and Benjamin Mahler.


Changes
---

Rebased.


Bugs: MESOS-9807
https://issues.apache.org/jira/browse/MESOS-9807


Repository: mesos


Description
---

This patch also introduces a constant `DEFAULT_QUOTA`.
By default, a role has no guarantees and no limits.


Diffs (updated)
-

  src/master/allocator/mesos/hierarchical.hpp 
1a3329d0e50ad2adb6aeadcd5d315eb572a85704 
  src/master/allocator/mesos/hierarchical.cpp 
ad0bcca90dcce4c9e8384293181c4f4af3d274aa 
  src/master/constants.hpp 8f729d18ec3678d97efbb74a8e816348c6acbeb4 


Diff: https://reviews.apache.org/r/70801/diff/2/

Changes: https://reviews.apache.org/r/70801/diff/1-2/


Testing
---

make check


Thanks,

Meng Zhu