Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

2019-07-05 Thread Benno Evers
> On July 3, 2019, 3:38 p.m., Benjamin Mahler wrote: > > Can you discard this patch in favor of the agreed upon interface? > > > > This patch looks pretty small outside of the interface changes, so it > > should be easy to re-work into the new approach? We don't want to commit a > > confusing

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

2019-07-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70883/#review216341 --- Can you discard this patch in favor of the agreed upon interface?

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

2019-07-02 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70883/ --- (Updated July 2, 2019, 5:29 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70883: Added optional 'peer_hostname' argument to Socket::connect().

2019-06-20 Thread Till Toenshoff via Review Board
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70883/#review216013 --- Ship it! We have discussed this patch a bit out of band and