Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-07-05 Thread Benno Evers
> On July 3, 2019, 4:07 p.m., Benjamin Mahler wrote: > > Was the benchmark done with an optimized build? > > Can you expand on the performance implications of this change in the > > description? (e.g. compare the min, 25th percentile, median, 75th > > percentile, max of at least 10 runs).

Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-07-03 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/#review216344 --- Ship it! Was the benchmark done with an optimized build? Can

Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-06-26 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 26, 2019, 1:37 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-06-24 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 24, 2019, 1:48 p.m.) Review request for mesos, Benjamin Mahler,

Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-06-21 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/#review216071 --- 3rdparty/libprocess/src/pid.cpp Lines 74 (patched)

Re: Review Request 70884: Added optional 'host' string member to UPID.

2019-06-21 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70884/ --- (Updated June 21, 2019, 10:25 p.m.) Review request for mesos, Joseph Wu and