Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 18-22 (patched)
> > 
> >
> > Is there any reason to keep these commented out chunks?

I believe it is valuable documentation, and does not distract that much.

Dropping this issue; please reopen if you feel strongly about this.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 25-30 (patched)
> > 
> >
> > Consider replacing the comment with a mention of the capital letter 
> > rule.
> > 
> > i.e. 
> > ```
> > # A commit title must start with a capital letter
> > # and end with a punctuation mark.
> > ```
> > 
> > Also, what do you think about allowing exclamation marks at the end? :)

Added a comment
```
# Mesos requires commit messages to start with a capital letter and end in a 
period.
```

> Also, what do you think about allowing exclamation marks at the end? :)

Let's discuss this separately.


> On Aug. 27, 2019, 8:02 p.m., Joseph Wu wrote:
> > support/gitlint
> > Lines 35-48 (patched)
> > 
> >
> > Do we need these chunks?

It serves as documentation, so not strictly _needed_ but useful nevertheless. 
Note that this file was bootrapped with `gitlint generate-config`.

Dropping; please reopen if you feel strongly about this.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217459
---


On Aug. 28, 2019, 11:04 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 28, 2019, 11:04 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/8/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-28 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/
---

(Updated Aug. 28, 2019, 11:04 a.m.)


Review request for mesos and Till Toenshoff.


Bugs: MESOS-9630
https://issues.apache.org/jira/browse/MESOS-9630


Repository: mesos


Description
---

This patch adds a config for the gitlint tool which is slated to replace
a custom commit-msg hook once we switch our hook infrastructure to the
pre-commit tool.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
  support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
  support/gitlint PRE-CREATION 


Diff: https://reviews.apache.org/r/71204/diff/8/

Changes: https://reviews.apache.org/r/71204/diff/7-8/


Testing
---

n/a


Thanks,

Benjamin Bannier



Re: Review Request 71204: Added gitlint config.

2019-08-27 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217459
---




bootstrap.bat
Lines 64 (patched)


s/mlink/mklink/



support/gitlint
Lines 18-22 (patched)


Is there any reason to keep these commented out chunks?



support/gitlint
Lines 25-30 (patched)


Consider replacing the comment with a mention of the capital letter rule.

i.e. 
```
# A commit title must start with a capital letter
# and end with a punctuation mark.
```

Also, what do you think about allowing exclamation marks at the end? :)



support/gitlint
Lines 35-48 (patched)


Do we need these chunks?


- Joseph Wu


On Aug. 14, 2019, 4:24 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 14, 2019, 4:24 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/7/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-26 Thread Till Toenshoff via Review Board

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217433
---


Ship it!




- Till Toenshoff


On Aug. 14, 2019, 11:24 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 14, 2019, 11:24 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/7/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-19 Thread Benno Evers

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/#review217280
---


Ship it!




Ship It!

- Benno Evers


On Aug. 14, 2019, 11:24 a.m., Benjamin Bannier wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71204/
> ---
> 
> (Updated Aug. 14, 2019, 11:24 a.m.)
> 
> 
> Review request for mesos and Till Toenshoff.
> 
> 
> Bugs: MESOS-9630
> https://issues.apache.org/jira/browse/MESOS-9630
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> This patch adds a config for the gitlint tool which is slated to replace
> a custom commit-msg hook once we switch our hook infrastructure to the
> pre-commit tool.
> 
> 
> Diffs
> -
> 
>   bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
>   bootstrap.bat 584b5c3ca228ff485b22473cd167d3f454d6dad4 
>   support/gitignore 7218eda0d78b8e6fc4568f215016961bd7a11a1b 
>   support/gitlint PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/71204/diff/7/
> 
> 
> Testing
> ---
> 
> n/a
> 
> 
> Thanks,
> 
> Benjamin Bannier
> 
>



Re: Review Request 71204: Added gitlint config.

2019-08-14 Thread Benjamin Bannier

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71204/
---

(Updated Aug. 14, 2019, 1:24 p.m.)


Review request for mesos and Till Toenshoff.


Changes
---

Link config with bootstrap


Bugs: MESOS-9360
https://issues.apache.org/jira/browse/MESOS-9360


Repository: mesos


Description
---

This patch adds a config for the gitlint tool which is slated to replace
a custom commit-msg hook once we switch our hook infrastructure to the
pre-commit tool.


Diffs (updated)
-

  bootstrap 7be2cc95c7ace55d710315427f38284cc5b2af4c 
  support/gitlint PRE-CREATION 


Diff: https://reviews.apache.org/r/71204/diff/2/

Changes: https://reviews.apache.org/r/71204/diff/1-2/


Testing
---

n/a


Thanks,

Benjamin Bannier