Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/#review217870 --- Patch looks great! Reviews applied: [71510, 71511, 71512] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 19, 2019, 6:30 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71512/ > --- > > (Updated Sept. 19, 2019, 6:30 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > For the test runner script to find the executable now, it needs > to be given the configuration and the file extension. > > > Diffs > - > > 3rdparty/libprocess/src/tests/CMakeLists.txt > b4ec9907d16c89b45562f4fa33c9f3d2913f6991 > > > Diff: https://reviews.apache.org/r/71512/diff/2/ > > > Testing > --- > > cmake --build . --target check (Windows) > > > Thanks, > > Joseph Wu > >
Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/ --- (Updated Sept. 19, 2019, 11:30 a.m.) Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. Changes --- Added comment explaining why the `$<>` expressions are present. Repository: mesos Description --- For the test runner script to find the executable now, it needs to be given the configuration and the file extension. Diffs (updated) - 3rdparty/libprocess/src/tests/CMakeLists.txt b4ec9907d16c89b45562f4fa33c9f3d2913f6991 Diff: https://reviews.apache.org/r/71512/diff/2/ Changes: https://reviews.apache.org/r/71512/diff/1-2/ Testing --- cmake --build . --target check (Windows) Thanks, Joseph Wu
Re: Review Request 71512: Windows: Libprocess: Fixed parallel test execution.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71512/#review217842 --- Patch looks great! Reviews applied: [71510, 71511, 71512] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers --disable-parallel-test-execution' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Sept. 18, 2019, 11 p.m., Joseph Wu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71512/ > --- > > (Updated Sept. 18, 2019, 11 p.m.) > > > Review request for mesos, Benjamin Bannier, Greg Mann, and Till Toenshoff. > > > Repository: mesos > > > Description > --- > > For the test runner script to find the executable now, it needs > to be given the configuration and the file extension. > > > Diffs > - > > 3rdparty/libprocess/src/tests/CMakeLists.txt > b4ec9907d16c89b45562f4fa33c9f3d2913f6991 > > > Diff: https://reviews.apache.org/r/71512/diff/1/ > > > Testing > --- > > cmake --build . --target check (Windows) > > > Thanks, > > Joseph Wu > >
