Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-08 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218579 --- Ship it! Ship It! - Benno Evers On Nov. 8, 2019, 12:48

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-08 Thread Benjamin Bannier
> On Nov. 6, 2019, 5:11 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 3810 (patched) > > > > > > It doesn't seem ideal to have recursively nested calls to > > `collectauthorizations()`, even if the

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-08 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/ --- (Updated Nov. 8, 2019, 1:48 p.m.) Review request for mesos and Benno Evers.

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-07 Thread Benno Evers
> On Nov. 6, 2019, 4:11 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 3810 (patched) > > > > > > It doesn't seem ideal to have recursively nested calls to > > `collectauthorizations()`, even if the

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-07 Thread Benjamin Bannier
> On Nov. 6, 2019, 5:11 p.m., Benno Evers wrote: > > src/master/master.cpp > > Lines 3810 (patched) > > > > > > It doesn't seem ideal to have recursively nested calls to > > `collectauthorizations()`, even if the

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-07 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/ --- (Updated Nov. 7, 2019, noon) Review request for mesos and Benno Evers. Bugs:

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-06 Thread Benno Evers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218545 --- src/master/master.cpp Lines 3810 (patched)

Re: Review Request 71729: Added authorization handling for reservations with `source`.

2019-11-06 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71729/#review218527 --- Bad review! Reviews applied: [71729] Error: No reviewers