Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-16 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219305 --- Bad patch! Reviews applied: [72002, 72003] Failed command: ['bas

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-16 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219304 --- Ship it! Ship It! - Andrei Sekretenko On Jan. 15, 2020, 3:12

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-16 Thread Benjamin Bannier
> On Jan. 15, 2020, 2:55 p.m., Andrei Sekretenko wrote: > > src/slave/slave.cpp > > Line 6583 (original), 6583 (patched) > > > > > > If we are not validating that `ExecutorInfo` of a task does not have > > `generat

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
> On Jan. 15, 2020, 2:55 p.m., Andrei Sekretenko wrote: > > src/slave/slave.cpp > > Line 6583 (original), 6583 (patched) > > > > > > If we are not validating that `ExecutorInfo` of a task does not have > > `generat

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219277 --- Bad patch! Reviews applied: [72002, 72003] Failed command: ['bas

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/ --- (Updated Jan. 15, 2020, 4:12 p.m.) Review request for mesos, Andrei Sekretenko

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Benjamin Bannier
> On Jan. 15, 2020, 2:55 p.m., Andrei Sekretenko wrote: > > src/slave/slave.cpp > > Lines 6593 (patched) > > > > > > The logic "executor is generated by agent -> master receives no > > updates" is not covered by an

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219272 --- Patch looks great! Reviews applied: [72002, 72003] Passed comman

Re: Review Request 72003: Used persisted information to decide if an executor is agent-generated.

2020-01-15 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72003/#review219270 --- src/slave/slave.cpp Line 6583 (original), 6583 (patched)