Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-27 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/#review222133 --- Bad patch! Reviews applied: [72964, 72955, 72956] Failed

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-27 Thread Andrei Sekretenko
> On Oct. 15, 2020, 11:22 p.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Line 2622 (original), 2622-2624 (patched) > > > > > > ``` > > Make sure the offer constraints don't use roles other than the

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-15 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/#review222061 --- Ship it! src/master/master.cpp Line 2622 (original),

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-14 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/#review222057 --- Bad review! Reviews applied: [72956, 72955, 72964] Error:

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-14 Thread Andrei Sekretenko
> On Oct. 14, 2020, 12:54 a.m., Benjamin Mahler wrote: > > src/master/master.cpp > > Line 2635 (original), 2635-2642 (patched) > > > > > > Ditto here from the last review, shouldn't this go into the > >

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-14 Thread Andrei Sekretenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/ --- (Updated Oct. 14, 2020, 8:18 p.m.) Review request for mesos and Benjamin

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-13 Thread Benjamin Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/#review222040 --- src/master/master.cpp Line 2635 (original), 2635-2642 (patched)

Re: Review Request 72956: Added validation that offer constraints are set only for existing roles.

2020-10-12 Thread Mesos Reviewbot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72956/#review222028 --- Patch looks great! Reviews applied: [72955, 72956] Passed