Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-24 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33491/#review81534 --- Ship it! Ship It! - Ben Mahler On April 23, 2015, 8:16 p.m.,

Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33491/ --- Review request for mesos. Bugs: MESOS-719

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
On April 23, 2015, 9:16 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 730 https://reviews.apache.org/r/33491/diff/1/?file=940552#file940552line730 I'm curious why you look at EPERM here, but not in the call to `::setgid` above and

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/33491/#review81407 --- Patch looks great! Reviews applied: [33491] All tests passed. -

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread James Peach
On April 23, 2015, 9:16 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 730 https://reviews.apache.org/r/33491/diff/1/?file=940552#file940552line730 I'm curious why you look at EPERM here, but not in the call to `::setgid` above and

Re: Review Request 33491: Set the supplementary groups list when switching users.

2015-04-23 Thread Ben Mahler
On April 23, 2015, 9:16 p.m., Ben Mahler wrote: 3rdparty/libprocess/3rdparty/stout/include/stout/os.hpp, line 730 https://reviews.apache.org/r/33491/diff/1/?file=940552#file940552line730 I'm curious why you look at EPERM here, but not in the call to `::setgid` above and