Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman 


> On May 18, 2015, 6:20 p.m., haosdent huang wrote:
> > configure.ac, line 650
> > 
> >
> > Should we change acx_pthread.m4 to ax_pthread.m4 here?
> 
> James Peach wrote:
> Updated the patch to alter the comments too.

I think you forgot to push the updated patch? Regardless, I fixed this before 
committing this for you James.


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84183
---


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-06-04 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review86598
---

Ship it!


Ship It!

- Benjamin Hindman


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-24 Thread haosdent huang 


> On May 18, 2015, 6:31 p.m., haosdent huang wrote:
> > m4/ax_python_devel.m4, line 268
> > 
> >
> > Could not understand why need add conf('SYSLIBS')) here? Could you 
> > explain this? Thank you
> 
> James Peach wrote:
> ``ax_python_devel.m4`` is taken unmodified from the autoconf archive. It 
> looks like ``SYSLIBS`` was added in commit 
> [6745ad4069f2fab26d72f374079cb8b7a4cf350f 
> ](http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commitdiff;h=6745ad4069f2fab26d72f374079cb8b7a4cf350f)

got it, Thank you. :-)


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84185
---


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-19 Thread James Peach 


> On May 18, 2015, 6:20 p.m., haosdent huang wrote:
> > configure.ac, line 650
> > 
> >
> > Should we change acx_pthread.m4 to ax_pthread.m4 here?

Updated the patch to alter the comments too.


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84183
---


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-19 Thread James Peach 


> On May 18, 2015, 6:31 p.m., haosdent huang wrote:
> > m4/ax_python_devel.m4, line 268
> > 
> >
> > Could not understand why need add conf('SYSLIBS')) here? Could you 
> > explain this? Thank you

``ax_python_devel.m4`` is taken unmodified from the autoconf archive. It looks 
like ``SYSLIBS`` was added in commit [6745ad4069f2fab26d72f374079cb8b7a4cf350f 
](http://git.savannah.gnu.org/gitweb/?p=autoconf-archive.git;a=commitdiff;h=6745ad4069f2fab26d72f374079cb8b7a4cf350f)


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84185
---


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84185
---



m4/ax_python_devel.m4


Could not understand why need add conf('SYSLIBS')) here? Could you explain 
this? Thank you


- haosdent huang


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-18 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review84183
---



configure.ac


Should we change acx_pthread.m4 to ax_pthread.m4 here?


- haosdent huang


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/#review82269
---


Patch looks great!

Reviews applied: [33753]

All tests passed.

- Mesos ReviewBot


On May 1, 2015, 4:02 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33753/
> ---
> 
> (Updated May 1, 2015, 4:02 p.m.)
> 
> 
> Review request for mesos.
> 
> 
> Bugs: MESOS-2659
> https://issues.apache.org/jira/browse/MESOS-2659
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
> configure.ac to use the autoconf macros.
> 
> 
> Diffs
> -
> 
>   configure.ac 589ae97d0432370b462576cd1985544564893999 
>   m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
>   m4/ax_pthread.m4 PRE-CREATION 
>   m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 
> 
> Diff: https://reviews.apache.org/r/33753/diff/
> 
> 
> Testing
> ---
> 
> Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
> Mac OS X 10.10.3.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 33753: Update pthread and python autoconf macros for Mesos.

2015-05-01 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33753/
---

Review request for mesos.


Bugs: MESOS-2659
https://issues.apache.org/jira/browse/MESOS-2659


Repository: mesos


Description
---

Replace acx_pthread with ax_pthread. Update ax_python_devel. Update
configure.ac to use the autoconf macros.


Diffs
-

  configure.ac 589ae97d0432370b462576cd1985544564893999 
  m4/acx_pthread.m4 2cf20de144a11be2aa603b04ea511244191037b7 
  m4/ax_pthread.m4 PRE-CREATION 
  m4/ax_python_devel.m4 3463d1430e16b7c9722319271e693e56bf1d323d 

Diff: https://reviews.apache.org/r/33753/diff/


Testing
---

Bootstrap and verify there are no autotools warnings. Tested on CentOS 7 and 
Mac OS X 10.10.3.


Thanks,

James Peach