Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33828/#review82462
---


Patch looks great!

Reviews applied: [33828]

All tests passed.

- Mesos ReviewBot


On May 4, 2015, 11:48 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/33828/
 ---
 
 (Updated May 4, 2015, 11:48 p.m.)
 
 
 Review request for mesos, Ben Mahler and Cody Maloney.
 
 
 Bugs: MESOS-2690
 https://issues.apache.org/jira/browse/MESOS-2690
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See Summary.
 
 
 Diffs
 -
 
   configure.ac 589ae97d0432370b462576cd1985544564893999 
 
 Diff: https://reviews.apache.org/r/33828/diff/
 
 
 Testing
 ---
 
 Built on gcc 4.9 with --enable-optimize. Verified the compilation warnings 
 are gone.
 Would love someone to confirm this does not break the clang builds.
 
 
 Thanks,
 
 Joris Van Remoortere

Re: Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33828/#review82464
---

Ship it!


Minor style/consistency nit, but otherwise shippable.


configure.ac
https://reviews.apache.org/r/33828/#comment133200

Style nit: Any reason you went with `+=` instead of `CXXFLAGS=${CXXFLAGS} 
-Wno-maybe-uninitialized` like the rest of the file?


- Adam B


On May 4, 2015, 4:48 p.m., Joris Van Remoortere wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/33828/
 ---
 
 (Updated May 4, 2015, 4:48 p.m.)
 
 
 Review request for mesos, Ben Mahler and Cody Maloney.
 
 
 Bugs: MESOS-2690
 https://issues.apache.org/jira/browse/MESOS-2690
 
 
 Repository: mesos
 
 
 Description
 ---
 
 See Summary.
 
 
 Diffs
 -
 
   configure.ac 589ae97d0432370b462576cd1985544564893999 
 
 Diff: https://reviews.apache.org/r/33828/diff/
 
 
 Testing
 ---
 
 Built on gcc 4.9 with --enable-optimize. Verified the compilation warnings 
 are gone.
 Would love someone to confirm this does not break the clang builds.
 
 
 Thanks,
 
 Joris Van Remoortere

Review Request 33828: Fix for MESOS-2690. Issue with enable-optimize build.

2015-05-04 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33828/
---

Review request for mesos, Ben Mahler and Cody Maloney.


Bugs: MESOS-2690
https://issues.apache.org/jira/browse/MESOS-2690


Repository: mesos


Description
---

See Summary.


Diffs
-

  configure.ac 589ae97d0432370b462576cd1985544564893999 

Diff: https://reviews.apache.org/r/33828/diff/


Testing
---

Built on gcc 4.9 with --enable-optimize. Verified the compilation warnings are 
gone.
Would love someone to confirm this does not break the clang builds.


Thanks,

Joris Van Remoortere