Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread James Peach 


> On June 4, 2015, 3:22 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/configure.ac, line 692
> > 
> >
> > I think you meant != here. ;-) How did this pass for you!?

That for fixing that. I think what happened was that the top level configure 
check already puked, so it never got to the point of running the libprocess 
configure :-/


- James


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86628
---


On May 15, 2015, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 15, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86628
---



3rdparty/libprocess/configure.ac


I think you meant != here. ;-) How did this pass for you!?


- Benjamin Hindman


On May 15, 2015, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 15, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman 


> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
> >

Just a heads up, you went from the +2 indentation in this file to +4 when you 
moved stuff around. I fixed it for you, but please keep the style consistent in 
the future, thanks!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
---


On May 15, 2015, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 15, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman 


> On June 4, 2015, 2:04 p.m., Benjamin Hindman wrote:
> > 3rdparty/libprocess/configure.ac, line 694
> > 
> >
> > s/Mesos/libprocess/

I took care of this fix for you James before committing. Thanks!


- Benjamin


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
---


On May 15, 2015, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 15, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-06-04 Thread Benjamin Hindman 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review86602
---

Ship it!



3rdparty/libprocess/configure.ac


s/Mesos/libprocess/


- Benjamin Hindman


On May 15, 2015, 4:24 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 15, 2015, 4:24 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-15 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/
---

(Updated May 15, 2015, 4:24 p.m.)


Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Bugs: MESOS-2666
https://issues.apache.org/jira/browse/MESOS-2666


Repository: mesos


Description
---

Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
the autoconf archive and use them to detect and configure the
supported copmilers.


Diffs (updated)
-

  3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
  3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
  3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 

Diff: https://reviews.apache.org/r/33850/diff/


Testing
---

Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 
GCC toolchain is still rejected as too old.


Thanks,

James Peach

Re: Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-05 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/#review82528
---


Patch looks great!

Reviews applied: [33850]

All tests passed.

- Mesos ReviewBot


On May 5, 2015, 3:53 p.m., James Peach wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/33850/
> ---
> 
> (Updated May 5, 2015, 3:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. 
> Clair.
> 
> 
> Bugs: MESOS-2666
> https://issues.apache.org/jira/browse/MESOS-2666
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
> the autoconf archive and use them to detect and configure the
> supported copmilers.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
>   3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
>   3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/33850/diff/
> 
> 
> Testing
> ---
> 
> Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 
> 6 GCC toolchain is still rejected as too old.
> 
> 
> Thanks,
> 
> James Peach
> 
>

Review Request 33850: libprocess: use standard macros for compiler and vendor detection

2015-05-05 Thread James Peach 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/33850/
---

Review request for mesos, Benjamin Hindman, Cody Maloney, and Timothy St. Clair.


Bugs: MESOS-2666
https://issues.apache.org/jira/browse/MESOS-2666


Repository: mesos


Description
---

Import the AX_COMPILER_VERSION and AX_COMPILER_VENDOR macros from
the autoconf archive and use them to detect and configure the
supported copmilers.


Diffs
-

  3rdparty/libprocess/configure.ac c5106cd09901781ca77d8c02c73919553a085876 
  3rdparty/libprocess/m4/ax_compiler_vendor.m4 PRE-CREATION 
  3rdparty/libprocess/m4/ax_compiler_version.m4 PRE-CREATION 

Diff: https://reviews.apache.org/r/33850/diff/


Testing
---

Make check on CentOS 7 and Mac OS X 10.10.3. Verified that the default CentOS 6 
GCC toolchain is still rejected as too old.


Thanks,

James Peach