Re: Review Request 34308: Filter revocable resources.
> On May 20, 2015, 12:34 a.m., Vinod Kone wrote: > > Ship It! I'll commit this for you, as I need this patch. - Vinod --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84426 --- On May 20, 2015, 12:29 a.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34308/ > --- > > (Updated May 20, 2015, 12:29 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Filter revocable resources. > > > Diffs > - > > include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 > src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 > src/tests/resources_tests.cpp 99b2cfc0149fb1a0ea66655caf67e9d966dae0c9 > > Diff: https://reviews.apache.org/r/34308/diff/ > > > Testing > --- > > > Thanks, > > Ian Downes > >
Re: Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84426 --- Ship it! Ship It! - Vinod Kone On May 20, 2015, 12:29 a.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34308/ > --- > > (Updated May 20, 2015, 12:29 a.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Filter revocable resources. > > > Diffs > - > > include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 > src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 > src/tests/resources_tests.cpp 99b2cfc0149fb1a0ea66655caf67e9d966dae0c9 > > Diff: https://reviews.apache.org/r/34308/diff/ > > > Testing > --- > > > Thanks, > > Ian Downes > >
Re: Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- (Updated May 19, 2015, 5:29 p.m.) Review request for mesos and Vinod Kone. Changes --- Added test. Repository: mesos Description --- Filter revocable resources. Diffs (updated) - include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 src/tests/resources_tests.cpp 99b2cfc0149fb1a0ea66655caf67e9d966dae0c9 Diff: https://reviews.apache.org/r/34308/diff/ Testing --- Thanks, Ian Downes
Re: Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84357 --- LGTM, modulo test, as Nik suggested. - Vinod Kone On May 18, 2015, 8:49 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34308/ > --- > > (Updated May 18, 2015, 8:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Filter revocable resources. > > > Diffs > - > > include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 > src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 > > Diff: https://reviews.apache.org/r/34308/diff/ > > > Testing > --- > > > Thanks, > > Ian Downes > >
Re: Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/#review84329 --- LGTM - want to add a test in src/tests/resources_tests.cpp too? - Niklas Nielsen On May 18, 2015, 1:49 p.m., Ian Downes wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34308/ > --- > > (Updated May 18, 2015, 1:49 p.m.) > > > Review request for mesos and Vinod Kone. > > > Repository: mesos > > > Description > --- > > Filter revocable resources. > > > Diffs > - > > include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 > src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 > > Diff: https://reviews.apache.org/r/34308/diff/ > > > Testing > --- > > > Thanks, > > Ian Downes > >
Re: Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- (Updated May 18, 2015, 1:49 p.m.) Review request for mesos and Vinod Kone. Changes --- Removed duplicate definitions that crept in. Repository: mesos Description --- Filter revocable resources. Diffs (updated) - include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 Diff: https://reviews.apache.org/r/34308/diff/ Testing --- Thanks, Ian Downes
Review Request 34308: Filter revocable resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34308/ --- Review request for mesos and Vinod Kone. Repository: mesos Description --- Filter revocable resources. Diffs - include/mesos/resources.hpp 1e98c13fe8075b14454f7899b98006fdaf88f484 src/common/resources.cpp 92b9e7f60323e0f7cf69c42e712468b631f3 Diff: https://reviews.apache.org/r/34308/diff/ Testing --- Thanks, Ian Downes
