Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 27, 2015, 11:56 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85454 --- Looks good. I'll commit this patch now. - Jie Yu On May 27, 2015,

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 27, 2015, 8:54 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 27, 2015, 6:50 p.m., Vinod Kone wrote: > > src/linux/routing/queueing/handle.hpp, line 69 > > > > > > why protected when you have a get()? It was protected in the merged filter::Handle. - Paul

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85405 --- src/Makefile.am

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review85272 --- src/linux/routing/queueing/ingress.cpp

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 26, 2015, 9:59 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84935 --- src/linux/routing/handle.hpp

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 22, 2015, 5:28 a.m., Cong Wang wrote: > > src/linux/routing/handle.hpp, line 118 > > > > > > Same comments near the definitions in handle.cpp, duplicated? > > Paul Brett wrote: > Once for the declaration

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 22, 2015, 5:28 a.m., Cong Wang wrote: > > src/linux/routing/handle.hpp, line 118 > > > > > > Same comments near the definitions in handle.cpp, duplicated? Once for the declaration, second for the definition.

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 22, 2015, 3:56 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84871 --- src/linux/routing/handle.hpp

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 22, 2015, 5:12 a.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 22, 2015, 4:51 a.m., Cong Wang wrote: > > You removed U32Handle too? How did this even compile? No, I moved it into src/linux/routing/handle.hpp - Paul --- This is an automatically generated e-mail. To reply, visit: https://rev

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 22, 2015, 5:07 a.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84867 --- You removed U32Handle too? How did this even compile? - Cong Wang

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 22, 2015, 4:42 a.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84835 --- src/linux/routing/queueing/handle.hpp

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

> On May 21, 2015, 10:09 p.m., Jie Yu wrote: > > src/linux/routing/handle.hpp, lines 68-77 > > > > > > Please put this funciton outside the Handle class. See > > src/linux/routing/filter/ip.hpp. > > > > BTW, i

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84796 --- Ship it! Looks good to me. A few style nits. Thanks for the merging

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84455 --- src/linux/routing/handle.hpp

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 19, 2015, 8:27 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 19, 2015, 7:54 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- (Updated May 19, 2015, 6:20 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/#review84229 --- Patch looks great! Reviews applied: [34321] All tests passed. - M

Review Request 34321: Merge class Handle which is duplicated between filter/handle and queueing/handle.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34321/ --- Review request for mesos. Bugs: mesos-2665 https://issues.apache.org/jira/b