Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-27 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 27, 2015, 6:05 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-27 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 27, 2015, 5:47 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-26 Thread Chi Zhang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review85295 --- Ship it! Modulo Vinod's comment - Chi Zhang On May 22, 2015, 5:2

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review85264 --- Ship it! src/slave/containerizer/isolators/network/port_mapping.cp

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-22 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 22, 2015, 5:28 p.m.) Review request for mesos, Chi Zhang, Ian Down

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-22 Thread Paul Brett
> On May 22, 2015, 7:31 a.m., Ian Downes wrote: > > src/slave/containerizer/isolators/network/port_mapping.hpp, lines 67-73 > > > > > > Please state why they are exposed. The same literarl strings are used in src/tests

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-22 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84885 --- src/slave/containerizer/isolators/network/port_mapping.hpp

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-21 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- (Updated May 21, 2015, 11:32 p.m.) Review request for mesos, Chi Zhang, Ian Dow

Re: Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/#review84609 --- Bad patch! Reviews applied: [34321, 34426, 34321] Failed command:

Review Request 34432: Remove duplicate constant string references to mesos-containerizer

2015-05-20 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34432/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: M