Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review86023 --- src/linux/routing/handle.hpp https://reviews.apache.org/r/34782/#comment137867 Do you want to make this a constexpr as well? src/linux/routing/queueing/ingress.hpp https://reviews.apache.org/r/34782/#comment137869 Can you do the following here? ``` constexpr Handle ROOT(TC_H_INGRESS); constexpr Handle HANDLE(0x, 0); ``` - Jie Yu On May 29, 2015, 8:36 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 8:36 p.m.) Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85761 --- Ship it! LGTM! I think this is what constexpr is introducd for, if it is cleared in the codebase. - Chi Zhang On May 29, 2015, 4:37 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 4:37 p.m.) Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
On May 29, 2015, 6:04 p.m., Chi Zhang wrote: LGTM! I think this is what constexpr is introducd for, if it is cleared in the codebase. Got ok on constexpr from mesosphere in email. - Paul --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85761 --- On May 29, 2015, 4:37 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 4:37 p.m.) Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85777 --- Ship it! src/linux/routing/queueing/fq_codel.cpp https://reviews.apache.org/r/34782/#comment137554 kill this? - Vinod Kone On May 29, 2015, 4:37 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 4:37 p.m.) Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 29, 2015, 8:36 p.m.) Review request for mesos, Ben Mahler, Chi Zhang, Ian Downes, Jie Yu, Vinod Kone, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs (updated) - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
Re: Review Request 34782: Convert Non-POD static variables in fq_codel and ingress to constexpr
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/#review85625 --- Patch looks great! Reviews applied: [34782] All tests passed. - Mesos ReviewBot On May 28, 2015, 8:28 p.m., Paul Brett wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34782/ --- (Updated May 28, 2015, 8:28 p.m.) Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs: MESOS-2778 https://issues.apache.org/jira/browse/MESOS-2778 Repository: mesos Description --- Convert Non-POD static variables in fq_codel and ingress to constexpr Diffs - src/linux/routing/handle.hpp 8f2da06207e426e2f2c0a8afa6976778023698c1 src/linux/routing/queueing/fq_codel.hpp 02486169a6d337d8b471b05a80e39803b0f1f790 src/linux/routing/queueing/fq_codel.cpp f9db58bbd39c1ebfd814ec2d1727e9cc80912762 src/linux/routing/queueing/ingress.hpp 4c96b604c7281ec95924c9c996dae6aed548627b src/linux/routing/queueing/ingress.cpp fece104648307e97755d5a38123e67c442a70474 Diff: https://reviews.apache.org/r/34782/diff/ Testing --- make check Thanks, Paul Brett
