Re: Review Request 34832: Add new qdisc tests

2015-06-03 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated June 3, 2015, 6:25 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34832: Add new qdisc tests

2015-06-03 Thread Jie Yu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review86458 --- Ship it! src/tests/routing_tests.cpp

Re: Review Request 34832: Add new qdisc tests

2015-06-02 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated June 2, 2015, 4:13 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34832: Add new qdisc tests

2015-06-01 Thread Ian Downes
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review86061 --- src/tests/routing_tests.cpp

Re: Review Request 34832: Add new qdisc tests

2015-06-01 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- (Updated June 1, 2015, 8:53 p.m.) Review request for mesos, Chi Zhang, Ian

Re: Review Request 34832: Add new qdisc tests

2015-06-01 Thread Paul Brett
On June 1, 2015, 8:23 p.m., Ian Downes wrote: src/tests/routing_tests.cpp, lines 452-453 https://reviews.apache.org/r/34832/diff/1/?file=974729#file974729line452 move this up to the ingress::create(noSuchInterface)? This and following is three tests are there to check that a remove

Review Request 34832: Add new qdisc tests

2015-05-29 Thread Paul Brett
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/ --- Review request for mesos, Chi Zhang, Ian Downes, Jie Yu, and Cong Wang. Bugs:

Re: Review Request 34832: Add new qdisc tests

2015-05-29 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34832/#review85838 --- Patch looks great! Reviews applied: [34830, 34832] All tests