Re: Review Request 34882: let mesos to compile and run on arm64 servers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/#review135983 --- This shouldn't be necessary to enable compilation on ARM any longer, right? If so, please mark this review request as discarded. - Neil Conway On June 1, 2015, 7:11 a.m., Dong Robin wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/34882/ > --- > > (Updated June 1, 2015, 7:11 a.m.) > > > Review request for mesos. > > > Bugs: MESOS-2786 > https://issues.apache.org/jira/browse/MESOS-2786 > > > Repository: mesos > > > Description > --- > > To build and run mesos on arm64(aarch64) servers, we add > the missing include header file, or it will report: > "pivot_root is not available" > > > Diffs > - > > 3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 > 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da > src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 > > Diff: https://reviews.apache.org/r/34882/diff/ > > > Testing > --- > > Build and run mesos-master/mesos slave successfully on arm64 server. > > > Thanks, > > Dong Robin > >
Re: Review Request 34882: let mesos to compile and run on arm64 servers
On 六月 1, 2015, 10:14 a.m., Mesos ReviewBot wrote: Bad patch! Reviews applied: [34882] Failed command: ./support/apply-review.sh -n -r 34882 Error: 2015-06-01 10:14:22 URL:https://reviews.apache.org/r/34882/diff/raw/ [4278/4278] - 34882.patch [1] 34882.patch:73: trailing whitespace. -lock xadd dword ptr [eax], ecx; 34882.patch:74: trailing whitespace. - lock xadd dword ptr [eax], ebx; 34882.patch:75: trailing whitespace. -mov result, ecx; // result = ebx; 34882.patch:77: trailing whitespace. - return result; warning: 4 lines add whitespace errors. Successfully applied: let mesos to compile and run on arm64 servers To build and run mesos on arm64(aarch64) servers, we add the missing include header file, or it will report: pivot_root is not available Review: https://reviews.apache.org/r/34882 3rdparty/zookeeper-3.4.5.patch:129: trailing whitespace. +-lock xadd dword ptr [eax], ecx; 3rdparty/zookeeper-3.4.5.patch:130: trailing whitespace. +- lock xadd dword ptr [eax], ebx; 3rdparty/zookeeper-3.4.5.patch:131: trailing whitespace. +-mov result, ecx; // result = ebx; 3rdparty/zookeeper-3.4.5.patch:133: trailing whitespace. +- return result; Failed to commit patch I have to add whitespace in patch as the source code in zookeeper*.tgz do have these whitespaces. - Dong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/#review85963 --- On 六月 1, 2015, 7:11 a.m., Dong Robin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/ --- (Updated 六月 1, 2015, 7:11 a.m.) Review request for mesos. Bugs: MESOS-2786 https://issues.apache.org/jira/browse/MESOS-2786 Repository: mesos Description --- To build and run mesos on arm64(aarch64) servers, we add the missing include header file, or it will report: pivot_root is not available Diffs - 3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 Diff: https://reviews.apache.org/r/34882/diff/ Testing --- Build and run mesos-master/mesos slave successfully on arm64 server. Thanks, Dong Robin
Review Request 34882: let mesos to compile and run on arm64 servers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/ --- Review request for mesos. Bugs: MESOS-2786 https://issues.apache.org/jira/browse/MESOS-2786 Repository: mesos Description --- To build and run mesos on arm64(aarch64) servers, we add the missing include header file, or it will report: pivot_root is not available Diffs - 3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 Diff: https://reviews.apache.org/r/34882/diff/ Testing --- Build and run mesos-master/mesos slave successfully on arm64 server. Thanks, Dong Robin
Re: Review Request 34882: let mesos to compile and run on arm64 servers
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/#review85963 --- Bad patch! Reviews applied: [34882] Failed command: ./support/apply-review.sh -n -r 34882 Error: 2015-06-01 10:14:22 URL:https://reviews.apache.org/r/34882/diff/raw/ [4278/4278] - 34882.patch [1] 34882.patch:73: trailing whitespace. -lock xadd dword ptr [eax], ecx; 34882.patch:74: trailing whitespace. - lock xadd dword ptr [eax], ebx; 34882.patch:75: trailing whitespace. -mov result, ecx; // result = ebx; 34882.patch:77: trailing whitespace. - return result; warning: 4 lines add whitespace errors. Successfully applied: let mesos to compile and run on arm64 servers To build and run mesos on arm64(aarch64) servers, we add the missing include header file, or it will report: pivot_root is not available Review: https://reviews.apache.org/r/34882 3rdparty/zookeeper-3.4.5.patch:129: trailing whitespace. +-lock xadd dword ptr [eax], ecx; 3rdparty/zookeeper-3.4.5.patch:130: trailing whitespace. +- lock xadd dword ptr [eax], ebx; 3rdparty/zookeeper-3.4.5.patch:131: trailing whitespace. +-mov result, ecx; // result = ebx; 3rdparty/zookeeper-3.4.5.patch:133: trailing whitespace. +- return result; Failed to commit patch - Mesos ReviewBot On June 1, 2015, 7:11 a.m., Dong Robin wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/34882/ --- (Updated June 1, 2015, 7:11 a.m.) Review request for mesos. Bugs: MESOS-2786 https://issues.apache.org/jira/browse/MESOS-2786 Repository: mesos Description --- To build and run mesos on arm64(aarch64) servers, we add the missing include header file, or it will report: pivot_root is not available Diffs - 3rdparty/leveldb.patch ad8c19b9caa856ff85978ba832d48df11b3a83f0 3rdparty/zookeeper-3.4.5.patch 3ca180d0c81f5de521ada7fb6c1c248a871ab2da src/linux/fs.cpp 1c9cf3f2ffead37148e4f6a81cefdbb97f679b09 Diff: https://reviews.apache.org/r/34882/diff/ Testing --- Build and run mesos-master/mesos slave successfully on arm64 server. Thanks, Dong Robin
