Re: Review Request 35024: Fixed _resources_used() to include only *regular* resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/#review86539 --- Patch looks great! Reviews applied: [35024] All tests passed. - Mesos ReviewBot On June 3, 2015, 10:08 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35024/ > --- > > (Updated June 3, 2015, 10:08 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2776 > https://issues.apache.org/jira/browse/MESOS-2776 > > > Repository: mesos > > > Description > --- > > - Otherwise the result `_resources_percent()` is wrong because the > `_resources_total()` only includes *regular* resources (from > slave->info.resources()). > > > Diffs > - > > src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d > > Diff: https://reviews.apache.org/r/35024/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jiang Yan Xu > >
Re: Review Request 35024: Fixed _resources_used() to include only *regular* resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/#review86505 --- Ship it! Ship It! - Vinod Kone On June 3, 2015, 10:08 p.m., Jiang Yan Xu wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/35024/ > --- > > (Updated June 3, 2015, 10:08 p.m.) > > > Review request for mesos and Vinod Kone. > > > Bugs: MESOS-2776 > https://issues.apache.org/jira/browse/MESOS-2776 > > > Repository: mesos > > > Description > --- > > - Otherwise the result `_resources_percent()` is wrong because the > `_resources_total()` only includes *regular* resources (from > slave->info.resources()). > > > Diffs > - > > src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d > > Diff: https://reviews.apache.org/r/35024/diff/ > > > Testing > --- > > make check > > > Thanks, > > Jiang Yan Xu > >
Review Request 35024: Fixed _resources_used() to include only *regular* resources.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35024/ --- Review request for mesos and Vinod Kone. Bugs: MESOS-2776 https://issues.apache.org/jira/browse/MESOS-2776 Repository: mesos Description --- - Otherwise the result `_resources_percent()` is wrong because the `_resources_total()` only includes *regular* resources (from slave->info.resources()). Diffs - src/master/master.cpp 710b8149c9d855d0f47cb2952366be10bc78c74d Diff: https://reviews.apache.org/r/35024/diff/ Testing --- make check Thanks, Jiang Yan Xu
