Re: Review Request 35036: Changed to use constexpr in MemoryTestHelper.

2016-07-09 Thread Joris Van Remoortere 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35036/#review141460
---



Closing this review due to inactivity. Please see our 
[guidelines](https://github.com/apache/mesos/blob/master/docs/reopening-reviews.md)
 for reopening reviews.

- Joris Van Remoortere


On June 3, 2015, 11:08 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35036/
> ---
> 
> (Updated June 3, 2015, 11:08 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed to use constexpr in MemoryTestHelper.
> 
> 
> Diffs
> -
> 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/35036/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Re: Review Request 35036: Changed to use constexpr in MemoryTestHelper.

2015-06-03 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35036/#review86534
---


Patch looks great!

Reviews applied: [31012, 32754, 32755, 32756, 32757, 35036]

All tests passed.

- Mesos ReviewBot


On June 3, 2015, 11:08 p.m., Chi Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35036/
> ---
> 
> (Updated June 3, 2015, 11:08 p.m.)
> 
> 
> Review request for mesos, Ian Downes and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Changed to use constexpr in MemoryTestHelper.
> 
> 
> Diffs
> -
> 
>   src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 
> 
> Diff: https://reviews.apache.org/r/35036/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Chi Zhang
> 
>

Review Request 35036: Changed to use constexpr in MemoryTestHelper.

2015-06-03 Thread Chi Zhang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35036/
---

Review request for mesos, Ian Downes and Jie Yu.


Repository: mesos


Description
---

Changed to use constexpr in MemoryTestHelper.


Diffs
-

  src/tests/memory_test_helper.cpp 8093e66c45cacc4bf0295a3448c128a1aa7c751a 

Diff: https://reviews.apache.org/r/35036/diff/


Testing
---


Thanks,

Chi Zhang