Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-10 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/#review87439
---

Ship it!


Ship It!

- Vinod Kone


On June 9, 2015, 7:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35259/
> ---
> 
> (Updated June 9, 2015, 7:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
> https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused constaints from ResourceMonitor.
> 
> 
> Diffs
> -
> 
>   src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 
> 
> Diff: https://reviews.apache.org/r/35259/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Niklas Nielsen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/#review87299
---

Ship it!


Ship It!

- Niklas Nielsen


On June 9, 2015, 12:50 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35259/
> ---
> 
> (Updated June 9, 2015, 12:50 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
> https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused constaints from ResourceMonitor.
> 
> 
> Diffs
> -
> 
>   src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 
> 
> Diff: https://reviews.apache.org/r/35259/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/
---

(Updated June 9, 2015, 7:50 p.m.)


Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Changes
---

Fixed the diff issue by rebasing the master.


Bugs: MESOS-2818
https://issues.apache.org/jira/browse/MESOS-2818


Repository: mesos


Description
---

Removed unused constaints from ResourceMonitor.


Diffs (updated)
-

  src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 

Diff: https://reviews.apache.org/r/35259/diff/


Testing
---

make check


Thanks,

Jie Yu



Re: Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Ben Mahler

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/#review87269
---


Looks like some unrelated changes snuck in?

- Ben Mahler


On June 9, 2015, 6:52 p.m., Jie Yu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/35259/
> ---
> 
> (Updated June 9, 2015, 6:52 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.
> 
> 
> Bugs: MESOS-2818
> https://issues.apache.org/jira/browse/MESOS-2818
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Removed unused constaints from ResourceMonitor.
> 
> 
> Diffs
> -
> 
>   src/linux/routing/queueing/fq_codel.hpp 
> 18c53b416718c27045986d939bb85f9fec731ca5 
>   src/linux/routing/queueing/fq_codel.cpp 
> 446863391d1c6dd2f91f890596927a20ee59a35f 
>   src/slave/containerizer/isolators/network/port_mapping.cpp 
> d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f 
>   src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 
>   src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 
> 
> Diff: https://reviews.apache.org/r/35259/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jie Yu
> 
>



Review Request 35259: Removed unused constaints from ResourceMonitor.

2015-06-09 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35259/
---

Review request for mesos, Ben Mahler, Niklas Nielsen, and Vinod Kone.


Bugs: MESOS-2818
https://issues.apache.org/jira/browse/MESOS-2818


Repository: mesos


Description
---

Removed unused constaints from ResourceMonitor.


Diffs
-

  src/linux/routing/queueing/fq_codel.hpp 
18c53b416718c27045986d939bb85f9fec731ca5 
  src/linux/routing/queueing/fq_codel.cpp 
446863391d1c6dd2f91f890596927a20ee59a35f 
  src/slave/containerizer/isolators/network/port_mapping.cpp 
d2da1a4e96baeac7d1af9a5468f90c2e4c1cb50f 
  src/slave/monitor.hpp bee91ba143c26059fc8badf56beccb68c6556cb7 
  src/tests/routing_tests.cpp 4be9967d38177d9f7def5c0da98d4c4266e7f0b5 

Diff: https://reviews.apache.org/r/35259/diff/


Testing
---

make check


Thanks,

Jie Yu