Review Request 35508: Improve readability in post-review

2015-06-16 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35508/
---

Review request for mesos, Ben Mahler and Vinod Kone.


Repository: mesos


Description
---

Section titles now append to the section they lead instead of the one above, 
i.e.:

```
Running 'rbt post' across all of ...
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
alexander/quickfix/post-review-spacing) Improve readability in post-review (46 
seconds ago)

Creating diff of:
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
alexander/quickfix/post-review-spacing) Improve readability in post-review

... with parent diff created from:
b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
Time object. (2 minutes ago)
Press enter to continue or 'Ctrl-C' to skip.
```

instead of:

```
Running 'rbt post' across all of ...
711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
alexander/quickfix/post-review-spacing) Improve readability in post-review (46 
seconds ago)
Creating diff of:

711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
alexander/quickfix/post-review-spacing) Improve readability in post-review
... with parent diff created from:

b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
Time object. (2 minutes ago)
Press enter to continue or 'Ctrl-C' to skip.
```


Diffs
-

  support/post-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf 

Diff: https://reviews.apache.org/r/35508/diff/


Testing
---


Thanks,

Alexander Rojas



Re: Review Request 35508: Improve readability in post-review

2015-06-16 Thread Marco Massenzio

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35508/#review88082
---


Beauty being in the eye of the beholder, I'm not entirely sure that I like the 
new version better (that is: assuming that the new and improved version is 
the bottom one?).

Can you please make the description clearer by stating: `will be` v. `is now`?
Thanks!

- Marco Massenzio


On June 16, 2015, 12:43 p.m., Alexander Rojas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35508/
 ---
 
 (Updated June 16, 2015, 12:43 p.m.)
 
 
 Review request for mesos, Ben Mahler and Vinod Kone.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Section titles now append to the section they lead instead of the one above, 
 i.e.:
 
 ```
 Running 'rbt post' across all of ...
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review 
 (46 seconds ago)
 
 Creating diff of:
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review
 
 ... with parent diff created from:
 b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
 Time object. (2 minutes ago)
 Press enter to continue or 'Ctrl-C' to skip.
 ```
 
 instead of:
 
 ```
 Running 'rbt post' across all of ...
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review 
 (46 seconds ago)
 Creating diff of:
 
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review
 ... with parent diff created from:
 
 b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
 Time object. (2 minutes ago)
 Press enter to continue or 'Ctrl-C' to skip.
 ```
 
 
 Diffs
 -
 
   support/post-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf 
 
 Diff: https://reviews.apache.org/r/35508/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Rojas
 




Re: Review Request 35508: Improve readability in post-review

2015-06-16 Thread Alexander Rojas


 On June 16, 2015, 6:40 p.m., Marco Massenzio wrote:
  Beauty being in the eye of the beholder, I'm not entirely sure that I like 
  the new version better (that is: assuming that the new and improved 
  version is the bottom one?).
  
  Can you please make the description clearer by stating: `will be` v. `is 
  now`?
  Thanks!

So you never get confused? Why would the title `Creating diff of:` should be in 
the line right after the previous git log and have a space to the commit you 
are actually creating the diff for?


- Alexander


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/35508/#review88082
---


On June 16, 2015, 2:43 p.m., Alexander Rojas wrote:
 
 ---
 This is an automatically generated e-mail. To reply, visit:
 https://reviews.apache.org/r/35508/
 ---
 
 (Updated June 16, 2015, 2:43 p.m.)
 
 
 Review request for mesos, Ben Mahler and Vinod Kone.
 
 
 Repository: mesos
 
 
 Description
 ---
 
 Section titles now append to the section they lead instead of the one above, 
 i.e.:
 
 ```
 Running 'rbt post' across all of ...
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review 
 (46 seconds ago)
 
 Creating diff of:
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review
 
 ... with parent diff created from:
 b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
 Time object. (2 minutes ago)
 Press enter to continue or 'Ctrl-C' to skip.
 ```
 
 instead of:
 
 ```
 Running 'rbt post' across all of ...
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review 
 (46 seconds ago)
 Creating diff of:
 
 711ffc86cd6485fe44218cefd92b036b5a850c19 - (HEAD - 
 alexander/quickfix/post-review-spacing) Improve readability in post-review
 ... with parent diff created from:
 
 b5eea1750953671fcd25963e5c5660ff40ca27f1 - Added stream manipulators for the 
 Time object. (2 minutes ago)
 Press enter to continue or 'Ctrl-C' to skip.
 ```
 
 
 Diffs
 -
 
   support/post-reviews.py ba016f5a12f438e4748ded48d5c0b96facf173cf 
 
 Diff: https://reviews.apache.org/r/35508/diff/
 
 
 Testing
 ---
 
 
 Thanks,
 
 Alexander Rojas