Re: Review Request 35766: Added --with-libnl=DIR configure flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/#review89034 --- Ship it! LGTM! configure.ac (lines 243 - 247) https://reviews.apache.org/r/35766/#comment141639 Could you please move this right below `--with-svn`? Also, s/libnl/nl/. Seems that we always strip the 'lib' prefix. ``` AC_ARG_WITH([nl], AS_HELP_STRING([--with-nl=@:@DIR@:@], [specify where to locate the libnl3 library (required for network-isolator). [default: /usr]]), [], []) ``` configure.ac (line 830) https://reviews.apache.org/r/35766/#comment141640 Please move this comments down. - Jie Yu On June 23, 2015, 6:18 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/ --- (Updated June 23, 2015, 6:18 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1856 https://issues.apache.org/jira/browse/MESOS-1856 Repository: mesos Description --- This allows us to specify alternate libnl installation location. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 Diff: https://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya
Re: Review Request 35766: Added --with-libnl=DIR configure flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/ --- (Updated June 23, 2015, 5:20 p.m.) Review request for mesos and Jie Yu. Changes --- Addressed Jie's comments. Bugs: MESOS-1856 https://issues.apache.org/jira/browse/MESOS-1856 Repository: mesos Description --- This allows us to specify alternate libnl installation location. Diffs (updated) - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 Diff: https://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya
Review Request 35766: Added --with-libnl=DIR configure flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/ --- Review request for mesos and Jie Yu. Bugs: MESOS-1856 https://issues.apache.org/jira/browse/MESOS-1856 Repository: mesos Description --- This allows us to specify alternate libnl installation location. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 Diff: https://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya
Re: Review Request 35766: Added --with-libnl=DIR configure flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/#review88932 --- Patch looks great! Reviews applied: [35585, 35586, 35762, 35765, 35766] All tests passed. - Mesos ReviewBot On June 23, 2015, 6:18 a.m., Kapil Arya wrote: --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/ --- (Updated June 23, 2015, 6:18 a.m.) Review request for mesos and Jie Yu. Bugs: MESOS-1856 https://issues.apache.org/jira/browse/MESOS-1856 Repository: mesos Description --- This allows us to specify alternate libnl installation location. Diffs - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 Diff: https://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya
Re: Review Request 35766: Added --with-libnl=DIR configure flag.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35766/ --- (Updated June 23, 2015, 2:18 a.m.) Review request for mesos and Jie Yu. Changes --- Added LDFLAGS. Bugs: MESOS-1856 https://issues.apache.org/jira/browse/MESOS-1856 Repository: mesos Description --- This allows us to specify alternate libnl installation location. Diffs (updated) - configure.ac 563e9c529444b3e980db6d04173f0d016a737c74 src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573 Diff: https://reviews.apache.org/r/35766/diff/ Testing --- Tested with: ``` ../configure --with-network-isolator --with-libnl=/usr/local LDFLAGS=-L/usr/local/lib64 ``` On systems that do not use `lib64` for 64-bit libraries, the LDFLAGS options isn't needed. Thanks, Kapil Arya
