Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

On July 2, 2015, 3:35 a.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/firewall.hpp, line 59 https://reviews.apache.org/r/35919/diff/4/?file=995819#file995819line59 Hm.. why is this an Ownedhttp::Response as opposed to just an http::Response? Is there something subtle

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

On July 2, 2015, 1:35 a.m., Ben Mahler wrote: 3rdparty/libprocess/include/process/firewall.hpp, line 59 https://reviews.apache.org/r/35919/diff/4/?file=995819#file995819line59 Hm.. why is this an Ownedhttp::Response as opposed to just an http::Response? Is there something subtle

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review90183 --- 3rdparty/libprocess/include/process/firewall.hpp (line 59)

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

On June 30, 2015, 6:08 a.m., Adam B wrote: Minor points, but otherwise shippable. I guess I'm still a little confused by the motivation. When would the firewall filter rule have more information about how to respond than the caller would? Can you give an example? The idea is to

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89880 --- Patch looks great! Reviews applied: [35919] All tests passed. -

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89728 --- Patch looks great! Reviews applied: [35919] All tests passed. -

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 29, 2015, 12:21 p.m.) Review request for mesos, Adam B and Till

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89715 --- Ship it! 3rdparty/libprocess/src/process.cpp (line 2017)

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89854 --- Ship it! Minor points, but otherwise shippable. I guess I'm still

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- (Updated June 26, 2015, 12:18 p.m.) Review request for mesos, Adam B and Till

Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/ --- Review request for mesos, Adam B and Till Toenshoff. Bugs: MESOS-2877

Re: Review Request 35919: Firewall rule's apply method returns an HTTP response instead of an error message.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/35919/#review89483 --- Patch looks great! Reviews applied: [35919] All tests passed. -